Review main Merged

81051[BUGFIX] Use CKEditor5 GHS attribute for CSS classes in link plugin

Benjamin Franzke CR +2 V +2 Normal +56 −26 updated 09/25/23, 08:35

Commit message

The GHS (General HTML Support [1]) attribute `htmlA` is used by the
style plugin to apply or remove style classes. Make sure to use the
same attribute interface in order for CSS class usage to be interopable
across our set of CKEditor5 plugins.

Note that our custom `linkClass` attribute prevented the CKEditor5
style plugin from parsing existing classes, as this plugin expects
CSS classes to be available on the `htmlA` attribute (defined in
the nested `classes` array).

[1] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1520

  1. Benjamin Franzke uploaded patch set 1 09/18/23, 16:36

  2. core-ci voted on patch set 1 V +1 09/18/23, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46687

  3. Benjamin Franzke uploaded patch set 2 V +1 09/21/23, 10:24

  4. core-ci voted on patch set 2 V +1 09/21/23, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47002

  5. Benni Mack voted on patch set 2 CR +1 09/21/23, 12:31

  6. Benni Mack commented on patch set 2 V +1 09/21/23, 12:41

    tough one, thank you!
  7. Benjamin Kott commented on patch set 2 V -1 09/21/23, 13:53

    - viewmodel is not updated correctly - class selector in linkbrowser does not show value if multiple selections exist
  8. Benni Mack commented on patch set 2 09/21/23, 13:55

    Can you share your config?
  9. Benjamin Kott commented on patch set 2 09/21/23, 13:57

    Reply

  10. Benjamin Franzke uploaded patch set 3 CR +1 V +1 09/22/23, 05:55

  11. Benjamin Franzke commented on patch set 3 09/22/23, 05:55

    Reply

    Thank you, good catches! I added some last minute changes to keep existing attributes when changing classes, that caused the view-representation to fail updated the visible classes (as I did not create a new attribute, but manipulated the existing one – that way data model was correct, but view was stale) Fixed that. > class selector in linkbrowser does not show value if multiple selections exist I think that might be an issue in bootstrap_package, because link-arrow is defined to be an allowed class in buttons.link.properties.class.allowedClasses, but it is not assigned to any classesAnchor definitions. Will talk to you later on that (and compare with v11 behaviour) …but as far as I see that'll be a separate patch if we can be more graceful on that part.
  12. core-ci voted on patch set 3 V +1 09/22/23, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47048

  13. Benjamin Franzke uploaded patch set 4 V +1 09/22/23, 06:17

  14. core-ci voted on patch set 4 V +1 09/22/23, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47049

  15. Benjamin Franzke updated the commit message in patch set 5 V +1 09/22/23, 08:56

  16. Benjamin Kott voted on patch set 5 V +1 CR +1 09/22/23, 09:11

  17. core-ci voted on patch set 5 V +1 09/22/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47064

  18. Andreas Kienast voted on patch set 5 V +1 CR +1 09/25/23, 07:31

  19. Benjamin Franzke voted on patch set 5 V +2 CR +2 09/25/23, 07:44

  20. Benjamin Franzke merged patch set 6 09/25/23, 08:35