81051[BUGFIX] Use CKEditor5 GHS attribute for CSS classes in link plugin
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 4
Review log 1520
-
Benjamin Franzke uploaded patch set 1 09/18/23, 16:36
-
core-ci voted on patch set 1 V +1 09/18/23, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46687
-
Benjamin Franzke uploaded patch set 2
V +109/21/23, 10:24 -
core-ci voted on patch set 2 V +1 09/21/23, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47002
-
Benni Mack voted on patch set 2 CR +1 09/21/23, 12:31
-
Benni Mack commented on patch set 2 V +1 09/21/23, 12:41
tough one, thank you! -
Benjamin Kott commented on patch set 2 V -1 09/21/23, 13:53
- viewmodel is not updated correctly - class selector in linkbrowser does not show value if multiple selections exist -
Benni Mack commented on patch set 2 09/21/23, 13:55
Can you share your config? -
Benjamin Kott commented on patch set 2 09/21/23, 13:57
Reply
https://github.com/benjaminkott/bootstrap_package/blob/master/Configuration/RTE/Default.yaml Still running the old config. Debugged this with @bnf -
Benjamin Franzke uploaded patch set 3
CR +1V +109/22/23, 05:55 -
Benjamin Franzke commented on patch set 3 09/22/23, 05:55
Reply
Thank you, good catches! I added some last minute changes to keep existing attributes when changing classes, that caused the view-representation to fail updated the visible classes (as I did not create a new attribute, but manipulated the existing one – that way data model was correct, but view was stale) Fixed that. > class selector in linkbrowser does not show value if multiple selections exist I think that might be an issue in bootstrap_package, because link-arrow is defined to be an allowed class in buttons.link.properties.class.allowedClasses, but it is not assigned to any classesAnchor definitions. Will talk to you later on that (and compare with v11 behaviour) …but as far as I see that'll be a separate patch if we can be more graceful on that part. -
core-ci voted on patch set 3 V +1 09/22/23, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47048
-
Benjamin Franzke uploaded patch set 4
V +109/22/23, 06:17 -
core-ci voted on patch set 4 V +1 09/22/23, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47049
-
Benjamin Franzke updated the commit message in patch set 5
V +109/22/23, 08:56 -
Benjamin Kott voted on patch set 5 V +1 CR +1 09/22/23, 09:11
-
core-ci voted on patch set 5 V +1 09/22/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47064
-
Andreas Kienast voted on patch set 5 V +1 CR +1 09/25/23, 07:31
-
Benjamin Franzke voted on patch set 5 V +2 CR +2 09/25/23, 07:44
-
Benjamin Franzke merged patch set 6 09/25/23, 08:35