Review 12.4 Merged

81055[TASK] Add tests for ContentObjectRenderer::listNum

Benni Mack CR +2 V +2 Normal +62 −10 updated 09/18/23, 13:26

Commit message

- Add unit tests for function ContentObjectRenderer::listNum()
- Improve code by renaming function argument ($char => $delimeter)
- Make sure arguments are always passed as strings (and not null)
  (as declared in PHPDoc)
- Improve clarity of description in PHPDoc

In the future typehints can be added for function arguments and
return type.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 09/18/23, 11:56

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/18/23, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46660

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/18/23, 13:26

  4. Christian Kuhn merged patch set 2 09/18/23, 13:26