81075[TASK] Use proper File objects in FileProcessingService
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 7
- Build/phpstan/phpstan-baseline.neon+1 −1
- typo3/sysext/core/Classes/Resource/Processing/ProcessorRegistry.php+6 −14
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+44 −75
- typo3/sysext/core/Classes/Resource/File.php2+1 −2
- typo3/sysext/core/Classes/Resource/ResourceStorage.php2+3 −11
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Tests/Unit/Resource/Processing/ProcessorRegistryTest.php+10 −3
Review log 2127
Show 12 earlier messages
-
Benni Mack uploaded patch set 1 09/18/23, 20:38
-
core-ci voted on patch set 1 V -1 09/18/23, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46712
-
Benni Mack uploaded patch set 2
V -109/18/23, 21:02 -
core-ci voted on patch set 2 V -1 09/18/23, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46716
-
Benni Mack uploaded patch set 3
V -109/18/23, 22:31 -
core-ci voted on patch set 3 V -1 09/18/23, 22:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46724
-
Benni Mack uploaded patch set 4
V -109/19/23, 07:50 -
core-ci voted on patch set 4 V +1 09/19/23, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46734
-
Oliver Klee commented on patch set 4 CR -1 09/19/23, 08:04
-
Oliver Klee commented on patch set 4 09/19/23, 08:19
File.php:239We can drop this annotation now that we have the type declaration.ResourceStorage.php:1384We can drop this annotation now that we have the type declaration. -
Benni Mack commented on patch set 4 09/19/23, 08:19
ProcessedFileRepository.php:45Replythe whole logic of $objectType is not really useful in this repository. I suggest to remove the dependency to the AbstractRepository and build the ProcessedFileRepository standalone, however, I'd like to this is as a separate change. -
Benni Mack uploaded patch set 5
CR -1V +109/19/23, 08:48 -
Oliver Klee commented on patch set 5 09/19/23, 08:57
ProcessedFileRepository.php:45ReplyThen at least we should update the comment here stating that this needs to be `ProcessedFile` or a subclass to avoid a type error. -
core-ci voted on patch set 5 V +1 09/19/23, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46741
-
Oliver Klee commented on patch set 5 09/19/23, 09:06
File.php:239ReplyDoneResourceStorage.php:1384ReplyDone -
Benni Mack commented on patch set 5 09/19/23, 09:20
ProcessedFileRepository.php:45ReplyWe could get this one in first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81081 -
Benni Mack commented on patch set 5 CR -2 09/19/23, 11:18
waiting for the repository changes to be merged first -
Benni Mack uploaded patch set 6
V +109/19/23, 12:45Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Benni Mack voted on patch set 6 CR 0 09/19/23, 12:45
-
Benni Mack commented on patch set 6 09/19/23, 12:50
ProcessedFileRepository.php:45ReplyDone -
core-ci voted on patch set 6 V +1 09/19/23, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46777
-
Oliver Klee voted on patch set 6 V +1 09/19/23, 14:15
-
Stefan Bürk voted on patch set 6 V +1 CR +1 09/19/23, 15:47
-
Oliver Klee voted on patch set 6 CR +1 09/19/23, 15:49
-
Benni Mack voted on patch set 6 V +2 CR +2 09/19/23, 16:02
-
Benni Mack merged patch set 7 09/19/23, 16:02
-
Benni Mack commented on patch set 7 09/19/23, 16:02
thank you
ProcessedFileRepository.php:45