81076[TASK] Ensure package dependencies in functional/acceptance tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Tests/Functional/SiteConfiguration/Fixtures/Extensions/test_configoverride_second/ext_emconf.php2+3 −2
- typo3/sysext/core/Tests/Functional/Package/PackageStatesTest.phpnew+154 −0
- typo3/sysext/form/composer.json+2 −1
- typo3/sysext/form/ext_emconf.php+1 −0
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlExports/irre-records.xml+506 −506
- typo3/sysext/impexp/Tests/Functional/Fixtures/XmlImports/irre-records.xml+506 −506
- composer.lock+4 −4
Review log 2538
Show 713 earlier messages
-
Oliver Hader uploaded patch set 1 09/18/23, 21:45
-
Oliver Hader marked it work in progress 09/18/23, 21:45
-
core-ci voted on patch set 1 V -1 09/18/23, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46721
-
Oliver Hader uploaded patch set 2
V -109/18/23, 21:50 -
core-ci voted on patch set 2 V -1 09/18/23, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46722
-
Oliver Hader uploaded patch set 3
V -109/18/23, 22:05 -
core-ci voted on patch set 3 V -1 09/18/23, 22:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46723
-
Oliver Hader uploaded patch set 4
V -109/19/23, 08:14 -
core-ci voted on patch set 4 V -1 09/19/23, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46738
-
Oliver Hader uploaded patch set 5
V -109/19/23, 10:30 -
Oliver Hader uploaded patch set 6 09/19/23, 10:44
-
core-ci voted on patch set 5 V -1 09/19/23, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46754
-
core-ci voted on patch set 6 V -1 09/19/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46757
-
Oliver Hader uploaded patch set 7
V -109/19/23, 11:05 -
core-ci voted on patch set 7 V +1 09/19/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46761
-
Oliver Hader updated the commit message in patch set 8
V +109/19/23, 11:54 -
core-ci voted on patch set 8 V +1 09/19/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46769
-
Oliver Hader rebased onto patch set 9
V +109/19/23, 14:18 -
core-ci voted on patch set 9 V +1 09/19/23, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46793
-
Oliver Hader uploaded patch set 10
V +109/19/23, 17:18 -
Oliver Hader commented on patch set 10 09/19/23, 17:20
This change is ready for review. -
core-ci voted on patch set 10 V +1 09/19/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46806
-
Stefan Bürk commented on patch set 10 09/19/23, 17:56
**Merger / Backport Info:** Tagged TF 8.0.6 containing the required change. 12.4 backport needs to require the new tag. -
Stefan Bürk commented on patch set 10 09/19/23, 18:05
ext_emconf.php:17Shoud this not be `test_configoverride_first` in suggest below instead of simple removing it ? composer.json suggests the other fixture extension. Guess, this have been overseen after some refactoring in this area. -
Oliver Hader uploaded patch set 11
V +109/19/23, 18:09 -
Oliver Hader commented on patch set 11 09/19/23, 18:11
ext_emconf.php:17ReplyDunno. I've added it to `suggests`, this way composer and extension dependencies are equal. -
Stefan Bürk voted on patch set 11 V +1 CR +1 09/19/23, 18:18
-
core-ci voted on patch set 11 V +1 09/19/23, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46819
-
Stefan Bürk commented on patch set 11 09/20/23, 07:33
Running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/46848 -
Anja Leichsenring voted on patch set 11 V +1 CR +1 09/20/23, 07:39
-
Stefan Bürk commented on patch set 11 CR -1 09/20/23, 07:41
waiting for nightly - will merge afterwards. -
core-ci voted on patch set 11 V -1 09/20/23, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46848
-
core-ci voted on patch set 11 V +1 09/20/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46848
-
Oliver Hader commented on patch set 11 09/20/23, 08:23
FYI: I'm already working on preparing the back-port -
Stefan Bürk commented on patch set 11 09/20/23, 08:24
Reply
i have already prepared the backport and running nightly on it ! -
Stefan Bürk voted on patch set 11 V +2 CR +2 09/20/23, 09:09
-
Stefan Bürk merged patch set 12 09/20/23, 09:09