Review main Merged

81076[TASK] Ensure package dependencies in functional/acceptance tests

Oliver Hader CR +2 V +2 Expert +1176 −1019 updated 09/20/23, 09:40

Commit message

This change uses the dependency ordering service in the method
`\TYPO3\TestingFramework\Core\Testbase::setUpPackageStates` for
test scenarios in functional and acceptance tests.

Besides that the following changes were applied:
* remove invalid dependency in fixture ext:test_configoverride_second
* add `PackageStatesTest` to keep track of extension dependencies
* add dependency to ext:frontend in ext:form, since it overrides
  TCA for the tables tt_content and sys_template (which would result
  in different ext:impexp results due to table field orderings)
* recreate IRRE related XML fixtures for ext:impexp since fixture
  extensions are now ordered alphabetically (and due to #100734)

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2538

Show 713 earlier messages
  1. Oliver Hader uploaded patch set 1 09/18/23, 21:45

  2. Oliver Hader marked it work in progress 09/18/23, 21:45

  3. core-ci voted on patch set 1 V -1 09/18/23, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46721

  4. Oliver Hader uploaded patch set 2 V -1 09/18/23, 21:50

  5. core-ci voted on patch set 2 V -1 09/18/23, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46722

  6. Oliver Hader uploaded patch set 3 V -1 09/18/23, 22:05

  7. core-ci voted on patch set 3 V -1 09/18/23, 22:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46723

  8. Oliver Hader uploaded patch set 4 V -1 09/19/23, 08:14

  9. core-ci voted on patch set 4 V -1 09/19/23, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46738

  10. Oliver Hader uploaded patch set 5 V -1 09/19/23, 10:30

  11. Oliver Hader uploaded patch set 6 09/19/23, 10:44

  12. core-ci voted on patch set 5 V -1 09/19/23, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46754

  13. core-ci voted on patch set 6 V -1 09/19/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46757

  1. Oliver Hader uploaded patch set 7 V -1 09/19/23, 11:05

  2. core-ci voted on patch set 7 V +1 09/19/23, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46761

  3. Oliver Hader updated the commit message in patch set 8 V +1 09/19/23, 11:54

  4. core-ci voted on patch set 8 V +1 09/19/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46769

  5. Oliver Hader rebased onto patch set 9 V +1 09/19/23, 14:18

  6. core-ci voted on patch set 9 V +1 09/19/23, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46793

  7. Oliver Hader uploaded patch set 10 V +1 09/19/23, 17:18

  8. Oliver Hader commented on patch set 10 09/19/23, 17:20

    This change is ready for review.
  9. core-ci voted on patch set 10 V +1 09/19/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46806

  10. Stefan Bürk commented on patch set 10 09/19/23, 17:56

    **Merger / Backport Info:** Tagged TF 8.0.6 containing the required change. 12.4 backport needs to require the new tag.
  11. Stefan Bürk commented on patch set 10 09/19/23, 18:05

    ext_emconf.php:17

    Shoud this not be `test_configoverride_first` in suggest below instead of simple removing it ? composer.json suggests the other fixture extension. Guess, this have been overseen after some refactoring in this area.
  12. Oliver Hader uploaded patch set 11 V +1 09/19/23, 18:09

  13. Oliver Hader commented on patch set 11 09/19/23, 18:11

    ext_emconf.php:17 Reply

    Dunno. I've added it to `suggests`, this way composer and extension dependencies are equal.
  14. Stefan Bürk voted on patch set 11 V +1 CR +1 09/19/23, 18:18

  15. core-ci voted on patch set 11 V +1 09/19/23, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46819

  16. Stefan Bürk commented on patch set 11 09/20/23, 07:33

  17. Anja Leichsenring voted on patch set 11 V +1 CR +1 09/20/23, 07:39

  18. Stefan Bürk commented on patch set 11 CR -1 09/20/23, 07:41

    waiting for nightly - will merge afterwards.
  19. core-ci voted on patch set 11 V -1 09/20/23, 08:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46848

  20. core-ci voted on patch set 11 V +1 09/20/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46848

  21. Oliver Hader commented on patch set 11 09/20/23, 08:23

    FYI: I'm already working on preparing the back-port
  22. Stefan Bürk commented on patch set 11 09/20/23, 08:24

    Reply

    i have already prepared the backport and running nightly on it !
  23. Stefan Bürk voted on patch set 11 V +2 CR +2 09/20/23, 09:09

  24. Stefan Bürk merged patch set 12 09/20/23, 09:09

  25. Oliver Hader commented on patch set 12 09/20/23, 09:40

    Reply

    Done
    Thx!