81081[!!!][TASK] Decouple FileRepository and ProcessedFileRepository
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Nedbal +1
- Oliver Klee +1
- Göran Bodenschatz +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Nedbal +1
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 14
- Build/phpstan/phpstan-baseline.neon+0 −10
- typo3/sysext/backend/Classes/View/BackendLayout/DefaultDataProvider.php+1 −1
- typo3/sysext/core/Classes/Controller/FileDumpController.php+3 −4
- typo3/sysext/core/Classes/Resource/AbstractRepository.phpdeleted+0 −320
- typo3/sysext/core/Classes/Resource/FileRepository.php9+51 −53
- typo3/sysext/core/Classes/Resource/ProcessedFileRepository.php2+107 −127
- typo3/sysext/core/Classes/ServiceProvider.php+4 −1
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101948-FileBasedAbstractRepositoryClassRemoved.rst2new+77 −0
- typo3/sysext/core/Tests/Unit/Resource/Repository/Fixtures/TestingRepository.phpdeleted+0 −36
- typo3/sysext/core/Tests/Unit/Resource/Repository/AbstractRepositoryTest.phpdeleted+0 −58
- typo3/sysext/frontend/Classes/Resource/FileCollector.php+4 −4
- typo3/sysext/install/Classes/Service/Typo3tempFileService.php+1 −2
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
Review log 2331
Show 46 earlier messages
-
Benni Mack uploaded patch set 1 09/19/23, 09:18
-
core-ci voted on patch set 1 V -1 09/19/23, 09:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46746
-
Oliver Klee commented on patch set 1 09/19/23, 09:50
-
Benni Mack uploaded patch set 2
V -109/19/23, 10:04 -
core-ci voted on patch set 2 V -1 09/19/23, 10:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46751
-
Benni Mack uploaded patch set 3
V -109/19/23, 10:25
-
Benni Mack commented on patch set 3 09/19/23, 10:26
FileRepository.php:54ReplyDone -
core-ci voted on patch set 3 V -1 09/19/23, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46753
-
Benni Mack uploaded patch set 4
V -109/19/23, 10:37 -
core-ci voted on patch set 4 V -1 09/19/23, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46756
-
Oliver Klee commented on patch set 4 CR -1 09/19/23, 10:53
Duplicate exception code 1314354065 in file: sysext/core/Classes/Resource/FileRepository.php -
Benni Mack uploaded patch set 5
CR -1V -109/19/23, 11:16 -
core-ci voted on patch set 5 V -1 09/19/23, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46762
-
Benni Mack uploaded patch set 6
V -109/19/23, 11:35 -
Göran Bodenschatz commented on patch set 5 09/19/23, 11:38
FileRepository.php:82`* @return FileReference[] An array of objects, empty if no objects found`FileRepository.php:164`* @return FileReference[]`Breaking-101948-FileBasedAbstractRepositoryClassRemoved.rst:38```that arose around :php:`AbstractRepository`.``` (space removed) -
core-ci voted on patch set 6 V +1 09/19/23, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46764
-
Oliver Klee commented on patch set 6 09/19/23, 11:48
FileRepository.php:164ReplyThen we'll also need this: `@param FileReference[]` -
Benni Mack uploaded patch set 7
V +109/19/23, 11:55 -
Benni Mack commented on patch set 7 09/19/23, 11:56
FileRepository.php:82ReplyDoneFileRepository.php:164ReplyDoneBreaking-101948-FileBasedAbstractRepositoryClassRemoved.rst:38ReplyDone -
Oliver Klee commented on patch set 6 V +1 09/19/23, 11:58
Looks very good all in all! I've added my comments on a few smaller things.FileRepository.php:187`@return 'FE|BE'`ProcessedFileRepository.php:130Can we directly use the `Context` instead (and split this into two statements instead of having one statement with two assignments)? -
core-ci voted on patch set 7 V +1 09/19/23, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46770
-
Benni Mack uploaded patch set 8
V +109/19/23, 12:38 -
Oliver Klee commented on patch set 8 09/19/23, 12:39
FileRepository.php:187ReplyDone -
core-ci voted on patch set 8 V +1 09/19/23, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46776
-
Benni Mack commented on patch set 8 09/19/23, 12:49
ProcessedFileRepository.php:130ReplyDone -
Christian Kuhn voted on patch set 8 V +1 CR +1 09/19/23, 13:05
-
Göran Bodenschatz voted on patch set 8 CR +1 09/19/23, 13:44
-
Andreas Nedbal voted on patch set 8 V +1 CR +1 09/19/23, 13:54
-
Oliver Klee voted on patch set 8 V +1 CR +1 09/19/23, 13:55
-
Benni Mack voted on patch set 8 V +2 CR +2 09/19/23, 13:55
-
Benni Mack merged patch set 9 09/19/23, 13:55
FileRepository.php:54