Review main Merged

81083[FEATURE] Allow updating online media assets

Oli Bartsch CR +2 V +2 Hard +312 −4 updated 09/19/23, 18:26

Commit message

A new controller is added, which allows
to update Metadata of online media assets.

This basically updates the preview image
and some basic data like author and the
assets dimensions.

To trigger the update, a new action is
available in the context menu and the
secondary dropdown of online media assets.

The functionality can be extended in the
future to update further information like
the asset's title. However, this needs some
more considerations, because an editor might
already changed the title intentionally.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Jochen Roth +1
    • Sebastian Tittel +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Jochen Roth +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 2124

  1. Oli Bartsch uploaded patch set 1 09/19/23, 10:58

  2. Guido Schmechel commented on patch set 1 09/19/23, 11:03

    FileUpdateOnlineMediaController.php:68

    Hi, I have already come into contact with this kind of code through my media extensions. My recommendation: I would decouple the deletion logic into a service. This way, you could theoretically also build CLI commands that regularly update media according to pattern x.
  3. core-ci voted on patch set 1 V -1 09/19/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46759

  4. Göran Bodenschatz commented on patch set 1 09/19/23, 11:11

    Routes.php:45

    I'd prefer strict snake case for keys.
  5. Oli Bartsch uploaded patch set 2 V -1 09/19/23, 13:56

  6. Oli Bartsch rebased onto patch set 3 09/19/23, 13:56

  7. Oli Bartsch commented on patch set 3 09/19/23, 13:57

    FileUpdateOnlineMediaController.php:68 Reply

    Done

    Routes.php:45 Reply

    Done
  8. core-ci voted on patch set 3 V +1 09/19/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46790

  9. Göran Bodenschatz voted on patch set 3 CR +1 09/19/23, 14:13

  10. Andreas Nedbal voted on patch set 3 V +1 CR +1 09/19/23, 14:24

  11. Oliver Hader commented on patch set 3 09/19/23, 14:52

    Should "reload metadata" show up in the tiles view as well?
  12. Oliver Hader commented on patch set 3 09/19/23, 15:04

    FileUpdateOnlineMediaController.php:51

    I'd suggest to add an HMAC verification on the input parameters
  13. Oliver Hader commented on patch set 3 09/19/23, 15:18

    FileUpdateOnlineMediaController.php:51 Reply

    Alternatively `$storage->checkFileActionPermission()`
  14. Oli Bartsch uploaded patch set 4 CR +1 V +1 09/19/23, 16:36

  15. Oli Bartsch commented on patch set 4 09/19/23, 16:36

    Reply

    Done

    FileUpdateOnlineMediaController.php:51 Reply

    Done
  16. Oliver Hader voted on patch set 4 CR +1 09/19/23, 16:41

  17. core-ci voted on patch set 4 V +1 09/19/23, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46802

  18. Oliver Hader voted on patch set 4 V +1 09/19/23, 16:47

  19. Andreas Nedbal voted on patch set 4 V +1 CR +1 09/19/23, 17:13

  20. Sebastian Tittel voted on patch set 4 CR +1 09/19/23, 17:16

  21. Benni Mack voted on patch set 4 CR +1 09/19/23, 17:25

  22. Jochen Roth voted on patch set 4 V +1 CR +1 09/19/23, 18:24

  23. Oli Bartsch voted on patch set 4 V +2 CR +2 09/19/23, 18:26

  24. Oli Bartsch merged patch set 5 09/19/23, 18:26