81083[FEATURE] Allow updating online media assets
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Nedbal +1
- Jochen Roth +1
- Sebastian Tittel +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Nedbal +1
- Jochen Roth +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 15
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+25 −0
- Build/Sources/TypeScript/filelist/file-list-actions.ts+4 −0
- Build/Sources/TypeScript/filelist/file-list.ts+26 −0
- typo3/sysext/core/Classes/Resource/OnlineMedia/Service/PreviewService.phpnew+55 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-82855-UpdateMetadataOfOnlineMediaAssets.rstnew+29 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −0
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+18 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+2 −0
- typo3/sysext/filelist/Classes/Controller/FileUpdateOnlineMediaController.php5new+94 −0
- typo3/sysext/filelist/Classes/FileList.php+41 −1
- typo3/sysext/filelist/Configuration/Backend/Routes.php2+6 −0
- typo3/sysext/filelist/Resources/Private/Language/locallang_mod_file_list.xlf+3 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
Review log 2124
-
Oli Bartsch uploaded patch set 1 09/19/23, 10:58
-
Guido Schmechel commented on patch set 1 09/19/23, 11:03
-
core-ci voted on patch set 1 V -1 09/19/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46759
-
Göran Bodenschatz commented on patch set 1 09/19/23, 11:11
Routes.php:45I'd prefer strict snake case for keys. -
Oli Bartsch uploaded patch set 2
V -109/19/23, 13:56 -
Oli Bartsch rebased onto patch set 3 09/19/23, 13:56
-
Oli Bartsch commented on patch set 3 09/19/23, 13:57
FileUpdateOnlineMediaController.php:68ReplyDoneRoutes.php:45ReplyDone -
core-ci voted on patch set 3 V +1 09/19/23, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46790
-
Göran Bodenschatz voted on patch set 3 CR +1 09/19/23, 14:13
-
Andreas Nedbal voted on patch set 3 V +1 CR +1 09/19/23, 14:24
-
Oliver Hader commented on patch set 3 09/19/23, 14:52
Should "reload metadata" show up in the tiles view as well? -
Oliver Hader commented on patch set 3 09/19/23, 15:04
FileUpdateOnlineMediaController.php:51I'd suggest to add an HMAC verification on the input parameters -
Oliver Hader commented on patch set 3 09/19/23, 15:18
FileUpdateOnlineMediaController.php:51ReplyAlternatively `$storage->checkFileActionPermission()` -
Oli Bartsch uploaded patch set 4
CR +1V +109/19/23, 16:36 -
Oli Bartsch commented on patch set 4 09/19/23, 16:36
Reply
DoneFileUpdateOnlineMediaController.php:51ReplyDone -
Oliver Hader voted on patch set 4 CR +1 09/19/23, 16:41
-
core-ci voted on patch set 4 V +1 09/19/23, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46802
-
Oliver Hader voted on patch set 4 V +1 09/19/23, 16:47
-
Andreas Nedbal voted on patch set 4 V +1 CR +1 09/19/23, 17:13
-
Sebastian Tittel voted on patch set 4 CR +1 09/19/23, 17:16
-
Benni Mack voted on patch set 4 CR +1 09/19/23, 17:25
-
Jochen Roth voted on patch set 4 V +1 CR +1 09/19/23, 18:24
-
Oli Bartsch voted on patch set 4 V +2 CR +2 09/19/23, 18:26
-
Oli Bartsch merged patch set 5 09/19/23, 18:26
FileUpdateOnlineMediaController.php:68