Review main Merged

81088[TASK] Use GraphicalFunctions instead of GifBuilder where applicable

Benni Mack CR +2 V +2 Easy +20 −19 updated 09/19/23, 18:15

Commit message

GifBuilder is currently a subclass of GraphicalFunctions.

Some places only use logic of GraphicalFunctions,
even though GifBuilder is instantiated.

This patch adapts these places.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack uploaded patch set 1 09/19/23, 16:35

  2. core-ci voted on patch set 1 V +1 09/19/23, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46801

  3. Benni Mack updated the commit message in patch set 2 V +1 09/19/23, 17:05

  4. core-ci voted on patch set 2 V +1 09/19/23, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46804

  5. Andreas Nedbal voted on patch set 2 V +1 CR +1 09/19/23, 18:05

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 09/19/23, 18:15

  7. Stefan Bürk merged patch set 3 09/19/23, 18:15