Review main Merged Breaking

81089[!!!][TASK] Move GIFBUILDER-specific methods into GifBuilder

Andreas Nedbal CR +2 V +2 Nightmare +2890 −2583 updated 09/20/23, 09:55

Commit message

A lot of the methods implemented in GraphicalFunctions are only
used in GifBuilder, thus it makes sense to move them into that
class. This also coincides with most of these methods utilizing
GDlib while the remaining methods in GraphicalFunctions now
mostly access and work with Image/GraphicsMagick.

In addition, some helper methods are in place in order
to keep the existing logic in the installer available
to verify image generation.

In the long term, a new API is introduced to utilize
base methods for GDLib and ImageMagick into separate classes
by encapsulating the actual commands,
whereas GifBuilder will remain the "TypoScript" entrypoint
to work with Images from cObjects.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1015

  1. Andreas Nedbal uploaded patch set 1 09/19/23, 16:51

  2. core-ci voted on patch set 1 V -1 09/19/23, 17:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46803

  3. Andreas Nedbal uploaded patch set 2 V -1 09/19/23, 17:43

  4. core-ci voted on patch set 2 V +1 09/19/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46812

  5. Benni Mack uploaded patch set 3 V +1 09/20/23, 07:13

  6. core-ci voted on patch set 3 V +1 09/20/23, 07:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46847

  7. Benni Mack uploaded patch set 4 V +1 09/20/23, 07:40

  8. Benni Mack uploaded patch set 5 09/20/23, 07:54

  9. core-ci voted on patch set 4 V +1 09/20/23, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46849

  10. core-ci voted on patch set 5 V +1 09/20/23, 08:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46850

  11. Benni Mack voted on patch set 5 V +1 CR +1 09/20/23, 08:12

  12. Stefan Bürk voted on patch set 5 CR +1 09/20/23, 08:12

  13. Stefan Bürk voted on patch set 5 V +1 09/20/23, 09:54

  14. Andreas Nedbal voted on patch set 5 V +2 CR +2 09/20/23, 09:54

  15. Andreas Nedbal merged patch set 6 09/20/23, 09:55