Review main Merged

81092[BUGFIX] Allow multiple CSS classes in link browser again

Torben Hansen CR +2 V +2 Easy +7 −9 updated 09/21/23, 10:47

Commit message

When a link is selected in CKEditor 5, the class `ck-link_selected` is
added to the link. This caused the link browser to not show the selected class, which has been fixed with #101436. The bugfix does however not consider, that a CSS class in link browser can consist of a string with multiple classes separated by a space.

This change ensures, that the link browser again accepts a class string
containing multiple class names and shows the selected class string in
the CSS-Class select field.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Torben Hansen uploaded patch set 1 09/20/23, 06:36

  2. core-ci voted on patch set 1 V +1 09/20/23, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46840

  3. Torben Hansen updated the commit message in patch set 2 V +1 09/20/23, 06:53

  4. core-ci voted on patch set 2 V +1 09/20/23, 07:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46842

  5. Benjamin Franzke commented on patch set 2 V +1 CR +1 09/21/23, 05:50

    The patch is good as is, thanks! BUT: I would actually prefer to have this fixed on the JavaScript side, in order to not even send these presentation classes. The issue is basically, that the link dialog works on the "visual" classes, instead of the classes of the object model (ckeditor has a data model and a representation). It will be a bit of a refactoring to streamline the JS plugin to do so, so I'd rather say: Let's take this patch for now and streamline/rework the JavaScript plugin with a separate TASK.
  6. Andreas Nedbal voted on patch set 2 V +1 CR +1 09/21/23, 08:32

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/21/23, 08:37

  8. Benjamin Franzke merged patch set 3 09/21/23, 10:47