Review main Merged

81097[BUGFIX] Use valid PHP 8 types related to GDImage in GifBuilder

Benni Mack CR +2 V +2 Hard +70 −212 updated 09/20/23, 14:55

Commit message

Since PHP 8.0, there is a new "\GDImage" object that
is used for image manipulation functions. Before,
this was a "resource", but can now be type-hinted properly
in all cases regarding GifBuilder.

This reduces the amount of PHPstan errors for GifBuilder et al
to a minimum.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1012

  1. Benni Mack uploaded patch set 1 09/20/23, 09:59

  2. core-ci voted on patch set 1 V +1 09/20/23, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46868

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 09/20/23, 10:08

  4. Andreas Nedbal commented on patch set 1 V -1 09/20/23, 10:38

    This patch makes the final environment/image processing test "Render 'niceText' with a shadow under" fail, the text is only rendered once.
  5. Benni Mack uploaded patch set 2 CR +1 V +1 09/20/23, 10:45

  6. Benni Mack commented on patch set 2 09/20/23, 10:47

    Reply

    Done
  7. Andreas Nedbal voted on patch set 2 V +1 CR +1 09/20/23, 10:49

  8. core-ci voted on patch set 2 V +1 09/20/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46875

  9. Oliver Klee commented on patch set 2 V +1 09/20/23, 11:38

    GifBuilder.php:131

    We can drop the PHPDoc annotation now that we have the native type declaration.

    GifBuilder.php:629

    We can drop the PHPDoc annotation now that we have the native type declaration. Ditto for the other places where we introduce the parameter type declaration.
  10. Oli Bartsch voted on patch set 2 V +1 CR +1 09/20/23, 14:53

  11. Stefan Bürk commented on patch set 2 V +2 CR +2 09/20/23, 14:55

    GifBuilder.php:131 Reply

    Done

    GifBuilder.php:629 Reply

    They have some descriptions.
  12. Stefan Bürk merged patch set 3 09/20/23, 14:55