81097[BUGFIX] Use valid PHP 8 types related to GDImage in GifBuilder
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Andreas Nedbal +1
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Andreas Nedbal +1
- Oli Bartsch +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1012
-
Benni Mack uploaded patch set 1 09/20/23, 09:59
-
core-ci voted on patch set 1 V +1 09/20/23, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46868
-
Christian Kuhn voted on patch set 1 V +1 CR +1 09/20/23, 10:08
-
Andreas Nedbal commented on patch set 1 V -1 09/20/23, 10:38
This patch makes the final environment/image processing test "Render 'niceText' with a shadow under" fail, the text is only rendered once. -
Benni Mack uploaded patch set 2
CR +1V +109/20/23, 10:45 -
Benni Mack commented on patch set 2 09/20/23, 10:47
Reply
Done -
Andreas Nedbal voted on patch set 2 V +1 CR +1 09/20/23, 10:49
-
core-ci voted on patch set 2 V +1 09/20/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46875
-
Oliver Klee commented on patch set 2 V +1 09/20/23, 11:38
GifBuilder.php:131We can drop the PHPDoc annotation now that we have the native type declaration.GifBuilder.php:629We can drop the PHPDoc annotation now that we have the native type declaration. Ditto for the other places where we introduce the parameter type declaration. -
Oli Bartsch voted on patch set 2 V +1 CR +1 09/20/23, 14:53
-
Stefan Bürk commented on patch set 2 V +2 CR +2 09/20/23, 14:55
GifBuilder.php:131ReplyDoneGifBuilder.php:629ReplyThey have some descriptions. -
Stefan Bürk merged patch set 3 09/20/23, 14:55