Review main Merged

81107[TASK] Centralize ImageMagick logic for FAL in GraphicalFunctions

Benni Mack CR +2 V +2 Normal +81 −96 updated 09/20/23, 22:45

Commit message

When FAL was introduced, some code from old GifBuilder
generation was copied to the Helper classes.

These now reside in GraphicalFunctions for further
refactorings and better API support.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1118

  1. Benni Mack uploaded patch set 1 09/20/23, 14:03

  2. core-ci voted on patch set 1 V +1 09/20/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46893

  3. Benni Mack uploaded patch set 2 V +1 09/20/23, 14:58

  4. core-ci voted on patch set 2 V +1 09/20/23, 15:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46903

  5. Benni Mack uploaded patch set 3 V +1 09/20/23, 19:09

  6. core-ci voted on patch set 3 V -1 09/20/23, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46918

  7. Benni Mack uploaded patch set 4 V -1 09/20/23, 19:52

  8. core-ci voted on patch set 4 V +1 09/20/23, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46925

  9. Benni Mack uploaded patch set 5 V +1 09/20/23, 21:43

  10. Benni Mack uploaded patch set 6 09/20/23, 21:46

  11. Benni Mack uploaded patch set 7 09/20/23, 21:54

  12. core-ci voted on patch set 5 V +1 09/20/23, 21:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46940

  13. core-ci voted on patch set 6 V +1 09/20/23, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46943

  14. core-ci voted on patch set 7 V +1 09/20/23, 22:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46945

  15. Stefan Bürk voted on patch set 7 V +1 CR +1 09/20/23, 22:19

  16. Andreas Nedbal voted on patch set 7 V +1 CR +1 09/20/23, 22:44

  17. Stefan Bürk voted on patch set 7 V +2 CR +2 09/20/23, 22:45

  18. Stefan Bürk merged patch set 8 09/20/23, 22:45