Review main Merged

81108[TASK] Treat image width as int instead of bool in EXT:indexed_search

Oliver Klee CR +2 V +2 Easy +1 −1 updated 09/21/23, 10:06

Commit message

The width of an image is an int and should not be used as a boolean.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Klee uploaded patch set 1 09/20/23, 14:10

  2. Oliver Klee updated the commit message in patch set 2 09/20/23, 14:11

  3. core-ci voted on patch set 2 V +1 09/20/23, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46896

  4. core-ci voted on patch set 1 V +1 09/20/23, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46895

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 09/20/23, 15:01

  6. Stefan Bürk voted on patch set 2 V +2 CR +2 09/20/23, 23:04

  7. Stefan Bürk merged patch set 3 09/20/23, 23:07

  8. Simon Schaufelberger commented on patch set 3 09/20/23, 23:33

    may I ask why this is a TASK and not a BUGFIX?
  9. Oliver Klee commented on patch set 3 09/21/23, 07:29

    Reply

    Of course! Honestly, it could have been either. I opted for TASK (or cleanup) because there was no actual bug (as the behavior was still correct) - the old code was only dirty and relied on PHP's implicit casting when an int is used in a condition.
  10. Simon Schaufelberger commented on patch set 3 09/21/23, 10:06

    Reply

    ok, thank you for your explanation.