81111[BUGFIX] Handle missing image dimensions gracefully
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/backend/Classes/Resource/Processing/DeferredBackendImageProcessor.php2+7 −1
- typo3/sysext/core/Classes/Imaging/Exception/ZeroImageDimensionException.php5new+28 −0
- typo3/sysext/core/Classes/Imaging/ImageDimension.php+2 −1
- typo3/sysext/core/Classes/Resource/Processing/SvgImageProcessor.php4+2 −1
Review log 1518
-
Nikita Hovratov uploaded patch set 1 09/20/23, 14:37
-
Oliver Klee voted on patch set 1 CR +1 09/20/23, 14:40
-
Andreas Kienast voted on patch set 1 CR +1 09/20/23, 14:44
-
Oli Bartsch commented on patch set 1 09/20/23, 14:51
-
core-ci voted on patch set 1 V +1 09/20/23, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46901
-
Nikita Hovratov uploaded patch set 2
CR +1V +109/20/23, 15:24 -
Nikita Hovratov commented on patch set 2 09/20/23, 15:26
DeferredBackendImageProcessor.php:53ReplyAdded a new custom Exception to be used in both processors. -
Oliver Klee commented on patch set 2 09/20/23, 15:28
ZeroImageDimensionException.php:23Nitpick: There should be no comma.ZeroImageDimensionException.php:26Maybe make it `final`?SvgImageProcessor.php:47`$e` is not needed here (only for the backports). -
core-ci voted on patch set 2 V +1 09/20/23, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46911
-
Nikita Hovratov commented on patch set 2 09/20/23, 15:38
ZeroImageDimensionException.php:26ReplyNot sure if this is really needed. Should be done for all Exceptions then, or?SvgImageProcessor.php:47ReplyI kept it for easier backports, yes. As long as we do not enforce omitting the variable, this does not hurt. -
Nikita Hovratov uploaded patch set 3
V +109/20/23, 15:38 -
Nikita Hovratov commented on patch set 2 09/20/23, 15:38
ZeroImageDimensionException.php:26ReplyDone -
Oliver Klee commented on patch set 3 V +1 CR +1 09/20/23, 15:40
SvgImageProcessor.php:47ReplyAck -
Oliver Klee commented on patch set 3 09/20/23, 15:40
ZeroImageDimensionException.php:23ReplyDone -
Stefan Bürk commented on patch set 3 V +1 CR +1 09/20/23, 15:44
SvgImageProcessor.php:47ReplyCould have been $_ do emphasize it and having easier backport. However, ok for now. -
core-ci voted on patch set 3 V +1 09/20/23, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46912
-
Stefan Bürk voted on patch set 3 V +2 CR +2 09/20/23, 19:35
-
Stefan Bürk merged patch set 4 09/20/23, 19:49
DeferredBackendImageProcessor.php:53