81112[TASK] Remove leftover IMGMENU code
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Nedbal +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Nedbal +1
- Oli Bartsch +1
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 4
Review log 1418
-
Stephan Großberndt uploaded patch set 1 09/20/23, 15:04
-
Andreas Kienast commented on patch set 1 09/20/23, 15:07
IMO it's fine to backport this to v12 as well -
Stephan Großberndt updated the commit message in patch set 2 09/20/23, 15:08
-
Stephan Großberndt commented on patch set 2 09/20/23, 15:10
Reply
I stumbled upon this while researching when the code removed in https://forge.typo3.org/issues/101973 actually went out of use. https://review.typo3.org/c/Packages/TYPO3.CMS/+/81104 targeted main only, so either both should be backported or the GifBuilder.php changes should be excluded from the backport. -
core-ci voted on patch set 1 V -1 09/20/23, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46906
-
core-ci voted on patch set 1 V -1 09/20/23, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46906
-
Andreas Kienast commented on patch set 2 09/20/23, 15:21
Reply
Ack. -
Andreas Kienast uploaded patch set 3 09/20/23, 15:21
-
Stephan Großberndt commented on patch set 2 09/20/23, 15:22
Could you help me please with getting grunt clean, Andreas? I do not have a setup here currently to run the build scripts... -
Andreas Kienast commented on patch set 3 09/20/23, 15:22
Reply
I've pushed PS 3 already ;) -
Stephan Großberndt commented on patch set 3 09/20/23, 15:23
Faster than I could ask! Thanks! ❤️ -
core-ci voted on patch set 2 V -1 09/20/23, 15:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46907
-
core-ci voted on patch set 3 V +1 09/20/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46910
-
Andreas Nedbal voted on patch set 3 V +1 CR +1 09/20/23, 15:53
-
Oliver Klee voted on patch set 3 V +1 09/20/23, 16:06
-
Oli Bartsch voted on patch set 3 V +1 CR +1 09/20/23, 18:59
-
Benni Mack voted on patch set 3 V +2 CR +2 09/20/23, 19:33
-
Benni Mack merged patch set 4 09/20/23, 19:33