Review main Merged

81120[BUGFIX] Prevent type errors on renaming and moving processed files

Oli Bartsch CR +2 V +2 Easy +4 −7 updated 09/20/23, 22:47

Commit message

Whenever a file is renamed or moved, also
the corresponding index entry is updated.

However this does only works and is only
relevant for File objects and can’t be
done for e.g. processed files.

Proper type checks for those two places
are added, preventing corresponding type
errors.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Oli Bartsch uploaded patch set 1 09/20/23, 21:39

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 09/20/23, 21:55

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/20/23, 22:04

  4. core-ci voted on patch set 1 V -1 09/20/23, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46939

  5. Stefan Bürk uploaded patch set 2 CR +1 V +1 09/20/23, 22:15

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 09/20/23, 22:15

  7. Benni Mack voted on patch set 2 V +1 CR +1 09/20/23, 22:35

  8. core-ci voted on patch set 2 V -1 09/20/23, 22:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46948

  9. core-ci voted on patch set 2 V +1 09/20/23, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46948

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 09/20/23, 22:47

  11. Stefan Bürk merged patch set 3 09/20/23, 22:47