81123[TASK] Move ImageMagick internals into GraphicalFunctions
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Jörg Bösche +1
- Andreas Kienast +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1724
-
Benni Mack uploaded patch set 1 09/20/23, 23:06
-
core-ci voted on patch set 1 V -1 09/20/23, 23:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46960
-
Benni Mack uploaded patch set 2
V -109/26/23, 08:29 -
core-ci voted on patch set 2 V -1 09/26/23, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47172
-
Benni Mack uploaded patch set 3
V -109/26/23, 10:53 -
core-ci voted on patch set 3 V -1 09/26/23, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47181
-
Benni Mack uploaded patch set 4
V -109/27/23, 11:19 -
core-ci voted on patch set 4 V -1 09/27/23, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47232
-
Benni Mack uploaded patch set 5
V -109/27/23, 11:46 -
Benni Mack uploaded patch set 6 09/27/23, 11:47
-
core-ci voted on patch set 5 V +1 09/27/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47236
-
core-ci voted on patch set 6 V +1 09/27/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47237
-
Andreas Kienast commented on patch set 6 09/27/23, 12:18
-
Stefan Bürk commented on patch set 6 CR -1 09/27/23, 13:19
on it ...GraphicalFunctions.php:764ReplyI would add a extra space here too to be save. -
Stefan Bürk uploaded patch set 7
CR -1V +109/27/23, 13:43 -
core-ci voted on patch set 7 V +1 09/27/23, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47246
-
Stefan Bürk commented on patch set 7 V +1 CR +1 09/27/23, 13:56
GraphicalFunctions.php:764ReplyDone -
Andreas Kienast voted on patch set 7 CR +1 09/27/23, 13:59
-
Jörg Bösche voted on patch set 7 CR +1 09/28/23, 11:03
-
Simon Schaufelberger commented on patch set 7 09/29/23, 20:47
GraphicalFunctions.php:106why did you only add here a type and not with the others as well? This variable is also not changed/touched in the code down below. Is this an unrelated code change? -
Christian Kuhn commented on patch set 7 10/04/23, 15:03
GraphicalFunctions.php:106Replychanging 'unrelated' type hints is not directly scope of this patch, so i guess this is why benni left it out. i'd say this is fine. -
Christian Kuhn voted on patch set 7 V +1 10/04/23, 15:04
-
Stefan Bürk voted on patch set 7 V +2 CR +2 10/04/23, 15:04
-
Stefan Bürk merged patch set 8 10/04/23, 15:04
GraphicalFunctions.php:764