Review main Merged

81123[TASK] Move ImageMagick internals into GraphicalFunctions

Benni Mack CR +2 V +2 Normal +60 −65 updated 10/04/23, 15:04

Commit message

The internal "stripProfile" check, and the checks for
"processor_enabled" are now encapsulated into
GraphicalFunctions.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jörg Bösche +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1724

  1. Benni Mack uploaded patch set 1 09/20/23, 23:06

  2. core-ci voted on patch set 1 V -1 09/20/23, 23:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46960

  3. Benni Mack uploaded patch set 2 V -1 09/26/23, 08:29

  4. core-ci voted on patch set 2 V -1 09/26/23, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47172

  5. Benni Mack uploaded patch set 3 V -1 09/26/23, 10:53

  6. core-ci voted on patch set 3 V -1 09/26/23, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47181

  7. Benni Mack uploaded patch set 4 V -1 09/27/23, 11:19

  8. core-ci voted on patch set 4 V -1 09/27/23, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47232

  9. Benni Mack uploaded patch set 5 V -1 09/27/23, 11:46

  10. Benni Mack uploaded patch set 6 09/27/23, 11:47

  11. core-ci voted on patch set 5 V +1 09/27/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47236

  12. core-ci voted on patch set 6 V +1 09/27/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47237

  13. Andreas Kienast commented on patch set 6 09/27/23, 12:18

    GraphicalFunctions.php:764

    I know it's the original code, but I wonder why we don't need a space character here. See `typo3_src/typo3/sysext/core/Classes/Utility/CommandUtility.php` for comparison.
  14. Stefan Bürk commented on patch set 6 CR -1 09/27/23, 13:19

    on it ...

    GraphicalFunctions.php:764 Reply

    I would add a extra space here too to be save.
  15. Stefan Bürk uploaded patch set 7 CR -1 V +1 09/27/23, 13:43

  16. core-ci voted on patch set 7 V +1 09/27/23, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47246

  17. Stefan Bürk commented on patch set 7 V +1 CR +1 09/27/23, 13:56

    GraphicalFunctions.php:764 Reply

    Done
  18. Andreas Kienast voted on patch set 7 CR +1 09/27/23, 13:59

  19. Jörg Bösche voted on patch set 7 CR +1 09/28/23, 11:03

  20. Simon Schaufelberger commented on patch set 7 09/29/23, 20:47

    GraphicalFunctions.php:106

    why did you only add here a type and not with the others as well? This variable is also not changed/touched in the code down below. Is this an unrelated code change?
  21. Christian Kuhn commented on patch set 7 10/04/23, 15:03

    GraphicalFunctions.php:106 Reply

    changing 'unrelated' type hints is not directly scope of this patch, so i guess this is why benni left it out. i'd say this is fine.
  22. Christian Kuhn voted on patch set 7 V +1 10/04/23, 15:04

  23. Stefan Bürk voted on patch set 7 V +2 CR +2 10/04/23, 15:04

  24. Stefan Bürk merged patch set 8 10/04/23, 15:04