Review main Merged

81127[FEATURE] Auto DB fields from TCA for type "text"

Anja Leichsenring CR +2 V +2 Normal +67 −58 updated 10/04/23, 16:05

Commit message

Tables with TCA columns set to type="text" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=text.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 2136

Show 511 earlier messages
  1. Anja Leichsenring uploaded patch set 1 09/21/23, 07:29

  2. core-ci voted on patch set 1 V -1 09/21/23, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46971

  3. Anja Leichsenring uploaded patch set 2 V -1 09/22/23, 04:49

  4. core-ci voted on patch set 2 V -1 09/22/23, 05:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47043

  5. Anja Leichsenring uploaded patch set 3 V -1 09/22/23, 05:23

  6. core-ci voted on patch set 3 V -1 09/22/23, 05:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47046

  7. core-ci commented on patch set 3 09/22/23, 05:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47046

  8. core-ci commented on patch set 3 09/22/23, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47046

  9. Anja Leichsenring uploaded patch set 4 V -1 09/22/23, 08:37

  10. core-ci voted on patch set 4 V -1 09/22/23, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47061

  11. Anja Leichsenring uploaded patch set 5 V -1 09/22/23, 09:03

  1. core-ci voted on patch set 5 V +1 09/22/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47067

  2. Nikita Hovratov commented on patch set 5 09/22/23, 10:45

    Getting this when trying to edit page properties: TYPO3\CMS\T3editor\Form\Element\T3editorElement::getHTMLCodeForEditor(): Argument #3 ($content) must be of type string, null given, called in /var/www/html/typo3/sysext/t3editor/Classes/Form/Element/T3editorElement.php on line 119
  3. Nikita Hovratov voted on patch set 5 V -1 09/22/23, 10:45

  4. Anja Leichsenring uploaded patch set 6 V +1 10/03/23, 09:38

  5. core-ci voted on patch set 6 V -1 10/03/23, 09:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47366

  6. Anja Leichsenring uploaded patch set 7 V -1 10/03/23, 10:02

  7. core-ci voted on patch set 7 V -1 10/03/23, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47367

  8. Anja Leichsenring uploaded patch set 8 V -1 10/03/23, 10:42

  9. core-ci voted on patch set 8 V -1 10/03/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47368

  10. Anja Leichsenring uploaded patch set 9 V -1 10/04/23, 05:16

  11. core-ci voted on patch set 9 V -1 10/04/23, 05:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47380

  12. Anja Leichsenring uploaded patch set 10 V -1 10/04/23, 05:33

  13. core-ci voted on patch set 10 V +1 10/04/23, 05:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47382

  14. Stefan Bürk voted on patch set 10 V +1 CR +1 10/04/23, 11:13

  15. Stefan Bürk voted on patch set 10 V 0 CR 0 10/04/23, 11:21

  16. Anja Leichsenring uploaded patch set 11 V +1 10/04/23, 11:21

  17. core-ci voted on patch set 11 V +1 10/04/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47392

  18. Anja Leichsenring rebased onto patch set 12 V +1 10/04/23, 14:33

  19. Nikita Hovratov uploaded patch set 13 10/04/23, 14:39

  20. core-ci voted on patch set 12 V +1 10/04/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47405

  21. core-ci voted on patch set 13 V +1 10/04/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47406

  22. Nikita Hovratov voted on patch set 13 V +1 CR +1 10/04/23, 15:46

  23. Christian Kuhn voted on patch set 13 V +1 CR +1 10/04/23, 16:05

  24. Stefan Bürk voted on patch set 13 V +2 CR +2 10/04/23, 16:05

  25. Stefan Bürk merged patch set 14 10/04/23, 16:05