Review main Merged

81129[TASK] Improve type annotations for ImageDimension

Oliver Klee CR +2 V +2 Easy +14 −0 updated 10/12/23, 11:08

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1622

  1. Oliver Klee uploaded patch set 1 09/21/23, 07:45

  2. core-ci voted on patch set 1 V +1 09/21/23, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46973

  3. Oliver Klee rebased onto patch set 2 V +1 09/22/23, 07:41

  4. core-ci voted on patch set 2 V +1 09/22/23, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47054

  5. Stefan Bürk commented on patch set 2 09/22/23, 17:17

    ImageDimension.php:129

    array<string|int|Area|bool>
  6. Oliver Klee commented on patch set 2 09/22/23, 17:21

    ImageDimension.php:129 Reply

    Done
  7. Oliver Klee uploaded patch set 3 V +1 09/22/23, 17:21

  8. core-ci voted on patch set 3 V +1 09/22/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47098

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 09/22/23, 21:20

  10. Benjamin Franzke commented on patch set 3 CR -1 09/25/23, 13:25

    ImageDimension.php:129

    Not helful to describe a generic array with *some* different values. We got defined keys here. If we really want to add typings, that'd probably be something like: @return array{ maxW?: int<0, max> maxH?: … … }
  11. Oliver Klee commented on patch set 3 09/25/23, 14:13

    Thanks for the review! I'll update this change accordingly.
  12. Oliver Klee marked it work in progress 09/25/23, 14:13

  13. Oliver Klee uploaded patch set 4 CR +1 V +1 10/08/23, 09:13

  14. Oliver Klee commented on patch set 4 10/08/23, 09:14

    This change is ready for review.

    ImageDimension.php:129 Reply

    Done
  15. core-ci voted on patch set 4 V +1 10/08/23, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47554

  16. Oliver Klee uploaded patch set 5 V +1 10/11/23, 11:57

  17. core-ci voted on patch set 5 V +1 10/11/23, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47679

  18. Oliver Klee rebased onto patch set 6 V +1 10/12/23, 08:31

  19. core-ci voted on patch set 6 V +1 10/12/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47704

  20. Benni Mack voted on patch set 6 V +1 CR +1 10/12/23, 10:13

  21. Christian Kuhn voted on patch set 6 V +2 CR +2 10/12/23, 11:08

  22. Christian Kuhn merged patch set 7 10/12/23, 11:08