81152[TASK] Remove unused ThumbnailController
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/backend/Classes/Controller/File/ThumbnailController.phpdeleted+0 −128
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+1 −1
- typo3/sysext/backend/Classes/ViewHelpers/ThumbnailViewHelper.php+2 −2
- typo3/sysext/backend/Configuration/Backend/Routes.php+0 −6
- typo3/sysext/backend/Tests/Unit/Controller/File/ThumbnailControllerTest.phpdeleted+0 −119
Review log 1520
-
Oli Bartsch uploaded patch set 1 09/21/23, 08:49
-
core-ci voted on patch set 1 V +1 09/21/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46988
-
Oliver Hader commented on patch set 1 09/21/23, 09:15
I searched for "/thumbnail" in the sources and still found references in comments in the `be:thumbnail` view helper and ´BackendUtility`. Could you please double check? -
Oli Bartsch uploaded patch set 2
V +109/21/23, 09:44 -
Oli Bartsch commented on patch set 2 09/21/23, 09:44
Reply
Thanks for checking. Those comments are outdated. I adjusted them. -
core-ci voted on patch set 2 V +1 09/21/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46994
-
Benni Mack uploaded patch set 3
V +109/21/23, 10:03 -
Benni Mack uploaded patch set 4 09/21/23, 10:06
-
Benni Mack voted on patch set 4 V +1 CR +1 09/21/23, 10:06
-
Oliver Klee voted on patch set 4 CR +1 09/21/23, 10:10
-
Oliver Klee commented on patch set 4 CR -1 09/21/23, 10:11
On it.We should add backticks around the annotation. Otherwise, the user "internal" on GitHub probably will get a notification after this is merged. -
Oliver Klee updated the commit message in patch set 5
CR +1V +109/21/23, 10:11 -
Oliver Klee commented on patch set 5 CR +1 09/21/23, 10:11
Reply
Done -
core-ci voted on patch set 3 V +1 09/21/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46996
-
core-ci voted on patch set 4 V +1 09/21/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46998
-
core-ci voted on patch set 5 V +1 09/21/23, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47000
-
Benni Mack voted on patch set 5 V +1 CR +1 09/21/23, 10:25
-
Stefan Bürk voted on patch set 5 V +1 CR +1 09/21/23, 10:33
-
Oli Bartsch voted on patch set 5 V +2 CR +2 09/21/23, 10:35
-
Oli Bartsch merged patch set 6 09/21/23, 10:35