Review main Merged

81152[TASK] Remove unused ThumbnailController

Oli Bartsch CR +2 V +2 Hard +3 −256 updated 09/21/23, 10:35

Commit message

The `@internal` `ThumbnailController` is removed,
because it has been unused since the introduction
of the deferred BE image processing in #92188.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1520

  1. Oli Bartsch uploaded patch set 1 09/21/23, 08:49

  2. core-ci voted on patch set 1 V +1 09/21/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46988

  3. Oliver Hader commented on patch set 1 09/21/23, 09:15

    I searched for "/thumbnail" in the sources and still found references in comments in the `be:thumbnail` view helper and ´BackendUtility`. Could you please double check?
  4. Oli Bartsch uploaded patch set 2 V +1 09/21/23, 09:44

  5. Oli Bartsch commented on patch set 2 09/21/23, 09:44

    Reply

    Thanks for checking. Those comments are outdated. I adjusted them.
  6. core-ci voted on patch set 2 V +1 09/21/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46994

  7. Benni Mack uploaded patch set 3 V +1 09/21/23, 10:03

  8. Benni Mack uploaded patch set 4 09/21/23, 10:06

  9. Benni Mack voted on patch set 4 V +1 CR +1 09/21/23, 10:06

  10. Oliver Klee voted on patch set 4 CR +1 09/21/23, 10:10

  11. Oliver Klee commented on patch set 4 CR -1 09/21/23, 10:11

    On it.
    We should add backticks around the annotation. Otherwise, the user "internal" on GitHub probably will get a notification after this is merged.
  12. Oliver Klee updated the commit message in patch set 5 CR +1 V +1 09/21/23, 10:11

  13. Oliver Klee commented on patch set 5 CR +1 09/21/23, 10:11

    Reply

    Done
  14. core-ci voted on patch set 3 V +1 09/21/23, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46996

  15. core-ci voted on patch set 4 V +1 09/21/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46998

  16. core-ci voted on patch set 5 V +1 09/21/23, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47000

  17. Benni Mack voted on patch set 5 V +1 CR +1 09/21/23, 10:25

  18. Stefan Bürk voted on patch set 5 V +1 CR +1 09/21/23, 10:33

  19. Oli Bartsch voted on patch set 5 V +2 CR +2 09/21/23, 10:35

  20. Oli Bartsch merged patch set 6 09/21/23, 10:35