Review main Merged

81154[TASK] Remove unused arguments in ThumbnailViewHelper

Oli Bartsch CR +2 V +2 Easy +0 −7 updated 09/21/23, 13:29

Commit message

Decoupling the ThumbnailViewHelper from the
ImageViewHelper in #96362, all arguments were
moved to the ThumbnailViewHelper. The commit
message as well as a code comment stated that
unneeded arguments will be removed later on.

This is now done. All unused arguments are
removed from the ViewHelper.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 89

  1. Oli Bartsch uploaded patch set 1 09/21/23, 10:30

  2. core-ci voted on patch set 1 V +1 09/21/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47003

  3. Oliver Hader voted on patch set 1 CR +1 09/21/23, 10:42

  4. Oliver Klee voted on patch set 1 CR +1 09/21/23, 10:47

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 09/21/23, 10:55

  6. Benni Mack voted on patch set 1 V +1 CR +1 09/21/23, 12:48

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 09/21/23, 12:48

  8. Oli Bartsch merged patch set 2 09/21/23, 12:48

  9. Andreas Kienast commented on patch set 2 09/21/23, 13:29

    I consider this patch a breaking change. If a 3rd party extension uses this VH with the now removed attributes, this will result in an exception.