81154[TASK] Remove unused arguments in ThumbnailViewHelper
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Oliver Klee +1
- Stefan Bürk +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 89
-
Oli Bartsch uploaded patch set 1 09/21/23, 10:30
-
core-ci voted on patch set 1 V +1 09/21/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47003
-
Oliver Hader voted on patch set 1 CR +1 09/21/23, 10:42
-
Oliver Klee voted on patch set 1 CR +1 09/21/23, 10:47
-
Stefan Bürk voted on patch set 1 V +1 CR +1 09/21/23, 10:55
-
Benni Mack voted on patch set 1 V +1 CR +1 09/21/23, 12:48
-
Oli Bartsch voted on patch set 1 V +2 CR +2 09/21/23, 12:48
-
Oli Bartsch merged patch set 2 09/21/23, 12:48
-
Andreas Kienast commented on patch set 2 09/21/23, 13:29
I consider this patch a breaking change. If a 3rd party extension uses this VH with the now removed attributes, this will result in an exception.