Review main Merged

81155[BUGFIX] Guard local storage with missing base folder in filelist

Stefan Bürk CR +2 V +2 Easy +23 −5 updated 09/27/23, 13:04

Commit message

Storages using the local storage driver with a non existing
base folder are put offline automatically. However, the file
list module displays a to generic error message not pointing
to that fact.

This change adds a concrete check for this case and displays
a more specific error flash message in the file list module now.

This can be tested by creating a additional local storage with
a non-existing relative path, for example:

    `fileadmin/not-existing-folder/`

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Stefan Bürk uploaded patch set 1 09/21/23, 12:57

  2. Stefan Bürk updated the commit message in patch set 2 09/21/23, 12:58

  3. core-ci voted on patch set 1 V +1 09/21/23, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47011

  4. core-ci voted on patch set 2 V +1 09/21/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47012

  5. Stefan Bürk rebased onto patch set 3 V +1 09/26/23, 10:19

  6. core-ci voted on patch set 3 V +1 09/26/23, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47177

  7. Oli Bartsch uploaded patch set 4 V +1 09/27/23, 09:31

  8. Oli Bartsch voted on patch set 4 V +1 CR +1 09/27/23, 09:32

  9. core-ci voted on patch set 4 V +1 09/27/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47222

  10. Andreas Kienast voted on patch set 4 CR +1 09/27/23, 12:31

  11. Andreas Kienast voted on patch set 4 V +1 09/27/23, 12:31

  12. Stefan Bürk voted on patch set 4 V +2 CR +2 09/27/23, 12:33

  13. Stefan Bürk merged patch set 5 09/27/23, 13:04