81156[BUGFIX] Restore file.crop syntax in PHP 8
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Benni Mack uploaded patch set 1 09/21/23, 13:42
-
core-ci voted on patch set 1 V +1 09/21/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47015
-
Oliver Klee voted on patch set 1 CR +1 09/21/23, 16:10
-
Oli Bartsch uploaded patch set 2
CR +1V +109/21/23, 16:56 -
Oli Bartsch voted on patch set 2 V +1 CR +1 09/21/23, 16:58
-
core-ci voted on patch set 2 V +1 09/21/23, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47023
-
Oliver Klee voted on patch set 2 CR +1 09/21/23, 17:13
-
Oliver Klee commented on patch set 2 09/21/23, 18:57
Is there any way we could cover this with a test? -
Oliver Klee commented on patch set 2 09/22/23, 16:57
Reply
Okay, let's skip the tests for this bugfix. -
Oliver Klee voted on patch set 2 V +1 09/22/23, 16:57
-
Stefan Bürk voted on patch set 2 V +2 CR +2 09/22/23, 17:18
-
Stefan Bürk merged patch set 3 09/22/23, 17:27