Review main Merged

81168[BUGFIX] Preserve allowedClasses (non classesAnchor) in link-browser

Benjamin Franzke CR +2 V +2 Easy +4 −2 updated 09/25/23, 08:37

Commit message

RTE link classes that are configured via
`buttons.link.properties.class.allowedClasses` are selectable
in all link types in the link browser.

Specific classes can be limited to specific link types with a
separate configuration option `classesAnchor.{id}.type|class`.
When such limits are active, classes that are *not* configured to
associated/limited to a specfic type, remain listed and available
for *all* link types.

When an existing link with such type of globally allowed class is opened
its value was cleared because it was not defined in the set of limits.
This was an inconsistency as the link class was still selectable, but
the selection was removed upon reoping such link. Such values are now
preserved.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Benjamin Franzke uploaded patch set 1 09/22/23, 08:08

  2. core-ci voted on patch set 1 V +1 09/22/23, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47055

  3. Benjamin Franzke uploaded patch set 2 V +1 09/22/23, 08:56

  4. Benjamin Kott voted on patch set 2 V +1 CR +1 09/22/23, 09:14

  5. core-ci voted on patch set 2 V +1 09/22/23, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47065

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 09/25/23, 08:14

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/25/23, 08:36

  8. Benjamin Franzke merged patch set 3 09/25/23, 08:37