81178[BUGFIX] Return empty string in case the folder does not exist
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Jochen Roth uploaded patch set 1 09/22/23, 11:13
-
Oliver Klee voted on patch set 1 CR +1 09/22/23, 11:17
-
core-ci voted on patch set 1 V +1 09/22/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47084
-
Georg Ringer commented on patch set 1 CR -1 09/22/23, 11:21
empty string is return, not nullFolderLinkHandler.php:49should we use ($parameters['folder'] ?? null) === null)? -
Oliver Klee commented on patch set 1 09/22/23, 11:36
FolderLinkHandler.php:49ReplyThe short version of this would be: ```php if (isset($parameters['folder'] )) { ``` -
Jochen Roth uploaded patch set 2
CR +1V +109/22/23, 12:02 -
Oliver Klee voted on patch set 2 CR +1 09/22/23, 12:06
-
core-ci voted on patch set 2 V +1 09/22/23, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47085
-
Georg Ringer voted on patch set 2 V +1 CR +1 09/22/23, 12:26
-
Stefan Bürk voted on patch set 2 V +2 CR +2 09/22/23, 13:00
-
Oli Bartsch commented on patch set 2 09/22/23, 13:08
instanceof check would be more explicit. $parameters['folder'] could still be set but not a Folder object. -
Stefan Bürk merged patch set 3 09/22/23, 13:08
-
Stefan Bürk commented on patch set 3 09/22/23, 13:11
Reply
Too late. Will create a follow up shortly.