Review main Merged

81180[TASK] Show Content Security Policy Mutations Configuration

Oliver Hader CR +2 V +2 Normal +97 −1 updated 10/26/23, 10:29

Commit message

The new section "Content Security Policy Mutations" in the
"Configuration" backend module shows the all available CSP
scopes, the compiled CSP header value and all involved
mutations in the order they are applied with their origins
(static package configuration or dynamic resolution item).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1622

  1. Oliver Hader uploaded patch set 1 09/22/23, 13:49

  2. core-ci voted on patch set 1 V -1 09/22/23, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47090

  3. Oliver Hader uploaded patch set 2 V -1 09/22/23, 16:00

  4. core-ci voted on patch set 2 V +1 09/22/23, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47094

  5. Chris Müller uploaded patch set 3 V +1 09/22/23, 18:37

  6. Chris Müller commented on patch set 3 V -1 09/22/23, 18:38

    On cache flush I am getting the error: Cannot autowire service "TYPO3\CMS\Lowlevel\ConfigurationModuleProvider\ProviderRegistry": argument "$mutationRepository" of method "TYPO3\CMS\Lowlevel\ConfigurationModuleProvider\Conte ntSecurityPolicyMutationsProvider::__construct()" has type "TYPO3\CMS\Core\Security\ContentSecurityPolicy\MutationRepository" but this class was not found. Obviously, the MutationRepository is not available?
  7. core-ci voted on patch set 3 V -1 09/22/23, 18:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47100

  8. Stefan Bürk commented on patch set 3 09/22/23, 21:19

    Reply

    This change was chained on other changes - but you checked out only this change directly and pushed it with the change, destroying the chain. The repository is now missing because it is not based upon other changes, for example this one introducing the repository: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81174 Please, be care full with changes that are part of a relation chain ;)
  9. Benjamin Franzke rebased onto patch set 4 V -1 09/25/23, 12:41

  10. Benjamin Franzke commented on patch set 4 09/25/23, 12:41

    Reply

    Fixed: I've rebased on the original relation chain and incorporated the docs-change from https://review.typo3.org/c/Packages/TYPO3.CMS/+/81180/2..3/typo3/sysext/lowlevel/Documentation/BackendModules/Configuration.rst
  11. core-ci voted on patch set 4 V +1 09/25/23, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47151

  12. Oliver Hader commented on patch set 4 09/25/23, 12:49

    This change is ready for review.
    Thx for establishing the relation chain again 👍 I'm removing the WIP flag here
  13. Benjamin Franzke uploaded patch set 5 V +1 10/26/23, 07:54

    Rebase
  14. Benjamin Franzke voted on patch set 5 V +1 CR +1 10/26/23, 07:55

  15. core-ci voted on patch set 5 V -1 10/26/23, 08:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48210

  16. Benjamin Franzke uploaded patch set 6 CR +1 V +1 10/26/23, 08:31

  17. Benjamin Franzke voted on patch set 6 V +1 CR +1 10/26/23, 08:31

  18. core-ci voted on patch set 6 V +1 10/26/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48214

  19. Stefan Bürk voted on patch set 6 V +1 CR +1 10/26/23, 09:26

  20. Oliver Hader voted on patch set 6 CR +2 10/26/23, 10:23

  21. Oliver Hader voted on patch set 6 V +2 10/26/23, 10:29

  22. Oliver Hader merged patch set 7 10/26/23, 10:29