Review main Merged

81181[TASK] Allow to omit tables in ext_tables.sql

Christian Kuhn CR +2 V +2 Normal +50 −41 updated 10/04/23, 14:29

Commit message

We are auto-creating more and more table columns
from TCA automatically with our works on #101553.
ext_tables.sql can now end up defining no column
of a table at all anymore.

The schema parser currently stumbles when a table
definition is completely left out in ext_tables.sql.

The patch allows omitting a table definition in
ext_tables.sql entirely.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 09/22/23, 17:10

  2. core-ci voted on patch set 1 V +1 09/22/23, 17:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47096

  3. Christian Kuhn uploaded patch set 2 V +1 10/04/23, 13:26

  4. core-ci voted on patch set 2 V +1 10/04/23, 13:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47402

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/04/23, 14:00

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 10/04/23, 14:17

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/04/23, 14:29

  8. Christian Kuhn merged patch set 3 10/04/23, 14:29