81263[DOCS] Add example for `Page Module` PSR-14 events
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Chris Müller +1
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Chris Müller +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1114
-
Stefan Bürk uploaded patch set 1 09/27/23, 10:18
-
Stefan Bürk uploaded patch set 2 09/27/23, 10:23
-
core-ci voted on patch set 1 V +1 09/27/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47229
-
core-ci voted on patch set 2 V +1 09/27/23, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47231
-
Chris Müller commented on patch set 2 CR -1 09/27/23, 11:06
@stefan Thanks for the work on this :-)Feature-98375-PSR-14EventsInPageModule.rst:105Add an additional ... -
Garvin Hicking commented on patch set 2 09/27/23, 12:12
Added suggestion to indicate that logic is meant to be adapted. Feel free to rephrase. ;-)Feature-98375-PSR-14EventsInPageModule.rst:58Add: // This code will be your domain logic to indicate if content should be hidden -
Stefan Bürk uploaded patch set 3
CR -1V +109/27/23, 13:14 -
Stefan Bürk commented on patch set 3 09/27/23, 13:14
Feature-98375-PSR-14EventsInPageModule.rst:58ReplyDoneFeature-98375-PSR-14EventsInPageModule.rst:105ReplyDone -
core-ci voted on patch set 3 V +1 09/27/23, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47243
-
Garvin Hicking commented on patch set 3 V +1 CR +1 09/27/23, 14:00
Will use the same for the Documentation PR now, thank you! -
Chris Müller voted on patch set 3 V +1 CR +1 09/27/23, 17:07
-
Georg Ringer voted on patch set 3 V +2 CR +2 09/27/23, 19:09
-
Georg Ringer merged patch set 4 09/27/23, 19:09
-
Simon Schaufelberger commented on patch set 4 09/27/23, 22:27
Unresolved
a typo. can you fix this in a followup commit?Feature-98375-PSR-14EventsInPageModule.rst:112Unresolvedan example