Review main Merged

81263[DOCS] Add example for `Page Module` PSR-14 events

Stefan Bürk CR +2 V +2 Normal +151 −0 updated 09/27/23, 22:27

Commit message

With #98375 hooks in the `Page Module` has been replaced by
modern PSR-14 events to customize the `Page Module` rendering.

The related PSR-14 events are:

* TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent
* TYPO3\CMS\Backend\View\Event\ModifyDatabaseQueryForContentEvent
* TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent

This change adds some basic example how to implement event listener
for these events to the corresponding feature ReST changelog file.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Chris Müller +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Chris Müller +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1114

  1. Stefan Bürk uploaded patch set 1 09/27/23, 10:18

  2. Stefan Bürk uploaded patch set 2 09/27/23, 10:23

  3. core-ci voted on patch set 1 V +1 09/27/23, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47229

  4. core-ci voted on patch set 2 V +1 09/27/23, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47231

  5. Chris Müller commented on patch set 2 CR -1 09/27/23, 11:06

    @stefan Thanks for the work on this :-)

    Feature-98375-PSR-14EventsInPageModule.rst:105

    Add an additional ...
  6. Garvin Hicking commented on patch set 2 09/27/23, 12:12

    Added suggestion to indicate that logic is meant to be adapted. Feel free to rephrase. ;-)

    Feature-98375-PSR-14EventsInPageModule.rst:58

    Add: // This code will be your domain logic to indicate if content should be hidden
  7. Stefan Bürk uploaded patch set 3 CR -1 V +1 09/27/23, 13:14

  8. Stefan Bürk commented on patch set 3 09/27/23, 13:14

    Feature-98375-PSR-14EventsInPageModule.rst:58 Reply

    Done

    Feature-98375-PSR-14EventsInPageModule.rst:105 Reply

    Done
  9. core-ci voted on patch set 3 V +1 09/27/23, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47243

  10. Garvin Hicking commented on patch set 3 V +1 CR +1 09/27/23, 14:00

    Will use the same for the Documentation PR now, thank you!
  11. Chris Müller voted on patch set 3 V +1 CR +1 09/27/23, 17:07

  12. Georg Ringer voted on patch set 3 V +2 CR +2 09/27/23, 19:09

  13. Georg Ringer merged patch set 4 09/27/23, 19:09

  14. Simon Schaufelberger commented on patch set 4 09/27/23, 22:27

    Unresolved

    a typo. can you fix this in a followup commit?

    Feature-98375-PSR-14EventsInPageModule.rst:112 Unresolved

    an example