Review main Merged

81266[BUGFIX] Use CKEditor5 data model as source for link-browser

Benjamin Franzke CR +2 V +2 Normal +49 −23 updated 10/02/23, 10:43

Commit message

Do not operate on the view model, but always read link attributes
from the data model. Do this to avoid conflicts with the (pre)view
representation of the contents which may not represent the plain data 1:1.

Examples:

 * CKEditor5 renderes phone links in the editor preview as `href="#"`.
   That means `href` must not be parsed from the link (#101303).
 * Link classes may be alterated with stateful style classes
   and had therefore be filtered server side previously (#101959).
   This is workaround could now be removed.

To make it clear that the result of getSelectedLinkElement() must
not be used as data source, the (more) correct return type
`ViewAttributeElement` is defined now (upstream does so too).

Note that CKEditor5 uses commands somewhat like data-models,
where the data is to be collected in the refresh() method.
This is why we process all link-related registered attribute in there,
(based on the CKEditor5 schema).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 913

  1. Benjamin Franzke uploaded patch set 1 09/27/23, 13:25

  2. core-ci voted on patch set 1 V +1 09/27/23, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47245

  3. Benjamin Franzke uploaded patch set 2 V +1 09/27/23, 14:16

  4. Benjamin Franzke voted on patch set 2 V -1 09/27/23, 14:18

  5. Benjamin Franzke uploaded patch set 3 V -1 09/27/23, 14:22

  6. core-ci voted on patch set 2 V +1 09/27/23, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47247

  7. core-ci voted on patch set 3 V +1 09/27/23, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47248

  8. Benjamin Franzke updated the commit message in patch set 4 V +1 09/27/23, 16:13

  9. core-ci voted on patch set 4 V +1 09/27/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47257

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 09/28/23, 09:14

  11. Benjamin Kott voted on patch set 4 V +1 CR +1 10/02/23, 10:22

  12. Benjamin Franzke voted on patch set 4 V +2 CR +2 10/02/23, 10:30

  13. Benjamin Franzke merged patch set 5 10/02/23, 10:43