Review main Merged

81268[TASK] Improve composer repository setup

Simon Schaufelberger CR +2 V +2 Normal +95 −90 updated 10/03/23, 17:28

Commit message

In order to test local composer packages, they need to be placed under
the "packages" directory in "Build/composer". To autoload these packages
automatically, the necessary setup is adjusted.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1520

  1. Simon Schaufelberger uploaded patch set 1 09/27/23, 20:37

  2. Simon Schaufelberger updated the commit message in patch set 2 09/27/23, 20:41

  3. core-ci voted on patch set 1 V +1 09/27/23, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47261

  4. core-ci voted on patch set 2 V +1 09/27/23, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47262

  5. Oliver Klee commented on patch set 2 09/28/23, 06:59

    typo: nessesary -> necessary

    composer.dist.json:58

    The new lines are indented with tabs, while the existing line are indented using spaces. Please let's make this consistent.
  6. Benjamin Franzke commented on patch set 2 09/28/23, 07:47

    composer.dist.json:57

    Please use "packages".
  7. Simon Schaufelberger commented on patch set 2 09/28/23, 08:27

    composer.dist.json:57 Reply

    i use local becaus this is the folder that is ignored in .gitignore. Then I need to change it there as well. What do you think?
  8. Simon Schaufelberger commented on patch set 2 09/29/23, 15:03

    Reply

    Done

    composer.dist.json:58 Reply

    mhh, the .editorconfig defines this: [*.json] indent_style = tab The best would be to reformat the whole file
  9. Simon Schaufelberger uploaded patch set 3 V +1 09/29/23, 15:03

  10. Simon Schaufelberger updated the commit message in patch set 4 09/29/23, 15:04

  11. core-ci voted on patch set 4 V +1 09/29/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47311

  12. core-ci voted on patch set 3 V +1 09/29/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47310

  13. Oliver Klee voted on patch set 4 CR +1 09/29/23, 15:24

  14. Benjamin Franzke uploaded patch set 5 CR +1 V +1 09/30/23, 11:36

  15. Benjamin Franzke commented on patch set 4 V +1 CR +1 09/30/23, 11:36

    composer.dist.json:57 Reply

    Right.

    composer.dist.json:58 Reply

    Ack, done.
  16. Benjamin Franzke voted on patch set 5 V +1 CR +1 09/30/23, 11:36

  17. core-ci voted on patch set 5 V +1 09/30/23, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47318

  18. Oliver Klee voted on patch set 5 V +1 CR +1 10/03/23, 16:07

  19. Benjamin Franzke voted on patch set 5 V +2 CR +2 10/03/23, 16:55

  20. Benjamin Franzke merged patch set 6 10/03/23, 17:28