Review main Merged

81269[BUGFIX] Hide deactivated options in CKEditor5 style dropdown

Benjamin Franzke CR +2 V +2 Easy +8 −0 updated 09/28/23, 10:03

Commit message

Adapt to the user expection for a style selector to only show
applicable styles. The list becomes overwhelming in case a lot of
specific styles (like table formatting) are shown for unrelated
elements.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 810

  1. Benjamin Franzke uploaded patch set 1 09/28/23, 05:50

  2. core-ci voted on patch set 1 V +1 09/28/23, 05:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47268

  3. Andreas Kienast commented on patch set 1 09/28/23, 06:01

    typo3-rte-ckeditor-ckeditor5.scss:2

    At first I wondered why there's a HEX color and why it looks weird. Perhaps add "See Forge" or alike for the next one seeing this.
  4. Benjamin Franzke commented on patch set 2 V +1 09/28/23, 06:42

    Published edit on patch set 1.
  5. Benjamin Franzke commented on patch set 2 09/28/23, 06:42

    typo3-rte-ckeditor-ckeditor5.scss:2 Reply

    Done
  6. core-ci voted on patch set 2 V +1 09/28/23, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47269

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 09/28/23, 07:41

  8. Oli Bartsch voted on patch set 2 V +1 CR +1 09/28/23, 08:00

  9. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/28/23, 09:25

  10. Benjamin Franzke merged patch set 3 09/28/23, 10:03