81296[BUGFIX] Improve CKEditor5 whitespace plugin usability
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/rte_ckeditor/plugin/whitespace.ts2+27 −20
- Build/Sources/TypeScript/rte_ckeditor/ckeditor5.ts+9 −7
- typo3/sysext/rte_ckeditor/Resources/Public/Css/editor.css+4 −12
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/whitespace.js+1 −1
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/ckeditor5.js+1 −1
Review log 2128
Show 23 earlier messages
-
Benjamin Franzke uploaded patch set 1 09/29/23, 05:01
-
core-ci voted on patch set 1 V +1 09/29/23, 05:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47297
-
Benjamin Franzke marked it ready for review 09/29/23, 05:39
-
Andreas Kienast commented on patch set 1 09/29/23, 06:48
I think this makes sense to do so -
Benjamin Franzke updated the commit message in patch set 2
V +109/30/23, 06:03 -
core-ci voted on patch set 2 V +1 09/30/23, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47316
-
Benjamin Franzke commented on patch set 2 09/30/23, 10:49
Reply
Ok, so, reality is: I don't know where to hook in, to do so. And I tried to find the place in ckeditor5 where they replace \u00A0 (non-breaking-space) with – but they don't. So I came to the conclusion that must be a platform thing and it turns out that's the case. Browser return \u00A0 encoded as in `.innerHTML`, but other whitespaces (that have entity representation) are not encoded. The reason is: https://html.spec.whatwg.org/multipage/parsing.html#escapingString > Replace any occurrences of the U+00A0 NO-BREAK SPACE character by the string " ". Also see https://bugzilla.mozilla.org/show_bug.cgi?id=165686#c28 why this behavior never changed. So I'd leave that "feature" out for reason of complexity for now. -
Benjamin Franzke uploaded patch set 3
V +110/02/23, 07:13 -
Benjamin Kott commented on patch set 2 CR -1 10/02/23, 07:13
whitespace.ts:34keystroke tooltip should respect differences between macos and other systems -
Benjamin Franzke uploaded patch set 4 10/02/23, 07:14
-
Benjamin Franzke commented on patch set 4 10/02/23, 07:14
whitespace.ts:34ReplyDone -
core-ci voted on patch set 4 V +1 10/02/23, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47334
-
Benjamin Franzke updated the commit message in patch set 5
V +110/02/23, 07:36 -
core-ci voted on patch set 5 V +1 10/02/23, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47336
-
Benjamin Franzke uploaded patch set 6
V +110/02/23, 09:05 -
core-ci voted on patch set 6 V +1 10/02/23, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47340
-
Benjamin Kott voted on patch set 6 V +1 CR +1 10/02/23, 10:12
-
Benjamin Franzke uploaded patch set 7
CR +1V +110/02/23, 10:49Rebase -
Benjamin Kott voted on patch set 7 V +1 CR +1 10/02/23, 10:51
-
core-ci voted on patch set 7 V +1 10/02/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47347
-
Benjamin Franzke uploaded patch set 8
CR +1V +110/04/23, 12:47 -
core-ci voted on patch set 8 V +1 10/04/23, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47398
-
Stefan Bürk voted on patch set 8 CR +1 10/06/23, 08:13
-
Stefan Bürk voted on patch set 8 V +1 10/06/23, 08:33
-
Oliver Hader voted on patch set 8 CR +1 10/06/23, 11:27
-
Oliver Hader commented on patch set 8 V +1 10/06/23, 11:33
Tested with macOS key combos -
Benjamin Franzke voted on patch set 8 V +2 CR +2 10/06/23, 13:12
-
Benjamin Franzke merged patch set 9 10/06/23, 13:40