81297[FEATURE] Introduce PSR-14 BeforeTcaOverridesEvent
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/core/Classes/Configuration/Event/BeforeTcaOverridesEvent.phpnew+41 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+11 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-102067-BeforeTcaOverridesEvent.rst3new+59 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_tca_event/Classes/EventListener/AddTcaAfterTcaCompilation.phpnew+32 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_tca_event/Classes/EventListener/AddTcaBeforeTcaOverrides.phpnew+33 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_tca_event/Configuration/TCA/Overrides/fruit.phpnew+6 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_tca_event/Configuration/TCA/fruit.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_tca_event/Configuration/Services.yamlnew+8 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_tca_event/composer.jsonnew+19 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_tca_event/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/Tca/AfterTcaCompilationEventTest.phpnew+35 −0
- typo3/sysext/core/Tests/Functional/Tca/BeforeTcaOverridesEventTest.phpnew+43 −0
- typo3/sysext/core/Tests/Unit/Utility/AccessibleProxies/ExtensionManagementUtilityAccessibleProxy.php+4 −0
- composer.json+1 −0
Review log 1519
-
Nikita Hovratov uploaded patch set 1 09/29/23, 11:18
-
core-ci voted on patch set 1 V -1 09/29/23, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47300
-
Nikita Hovratov uploaded patch set 2
V -109/29/23, 12:19 -
core-ci voted on patch set 2 V +1 09/29/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47303
-
Oli Bartsch voted on patch set 2 CR +1 09/29/23, 13:47
-
Georg Ringer commented on patch set 2 09/30/23, 07:44
isn't that we should also backport to 12? -
Oli Bartsch voted on patch set 2 V +1 10/02/23, 09:32
-
Nikita Hovratov commented on patch set 2 10/02/23, 09:49
Reply
It's a feature, so no I guess? I need it for Content Blocks in v13. For now the other event is sufficient. -
Stefan Bürk commented on patch set 3
CR +1V +110/05/23, 09:20Published edit on patch set 2. -
Stefan Bürk voted on patch set 3 V +1 CR +1 10/05/23, 09:22
-
core-ci voted on patch set 3 V +1 10/05/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47430
-
Christian Kuhn commented on patch set 3 10/05/23, 09:55
Feature-102067-BeforeTcaOverridesEvent.rst:49I think this should include a note that TCA is 'runtime cached': TCA is built exactly once, so any 'dynamic' additions must never create state from runtime state like depending on given request or similar, which may not even exist when first call is from cli for instance. -
Stefan Bürk voted on patch set 3 V 0 CR 0 10/05/23, 12:35
-
Stefan Bürk commented on patch set 3 10/05/23, 12:35
Feature-102067-BeforeTcaOverridesEvent.rst:49Replygood point -
Oli Bartsch uploaded patch set 4
V +110/05/23, 14:12 -
Oli Bartsch commented on patch set 4 V +1 CR +1 10/05/23, 14:12
Feature-102067-BeforeTcaOverridesEvent.rst:49ReplyDone -
core-ci voted on patch set 4 V +1 10/05/23, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47444
-
Stefan Bürk voted on patch set 4 V +2 CR +2 10/05/23, 14:19
-
Stefan Bürk merged patch set 5 10/05/23, 14:19