Review main Merged

81297[FEATURE] Introduce PSR-14 BeforeTcaOverridesEvent

Nikita Hovratov CR +2 V +2 Hard +334 −0 updated 10/05/23, 14:19

Commit message

This event can be used to dynamically generate TCA and add it as
additional base TCA. This is especially useful for "TCA generator"
extensions, which add TCA based on another resource, while still
enabling users to override TCA via TCA overrides as usual.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1519

  1. Nikita Hovratov uploaded patch set 1 09/29/23, 11:18

  2. core-ci voted on patch set 1 V -1 09/29/23, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47300

  3. Nikita Hovratov uploaded patch set 2 V -1 09/29/23, 12:19

  4. core-ci voted on patch set 2 V +1 09/29/23, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47303

  5. Oli Bartsch voted on patch set 2 CR +1 09/29/23, 13:47

  6. Georg Ringer commented on patch set 2 09/30/23, 07:44

    isn't that we should also backport to 12?
  7. Oli Bartsch voted on patch set 2 V +1 10/02/23, 09:32

  8. Nikita Hovratov commented on patch set 2 10/02/23, 09:49

    Reply

    It's a feature, so no I guess? I need it for Content Blocks in v13. For now the other event is sufficient.
  9. Stefan Bürk commented on patch set 3 CR +1 V +1 10/05/23, 09:20

    Published edit on patch set 2.
  10. Stefan Bürk voted on patch set 3 V +1 CR +1 10/05/23, 09:22

  11. core-ci voted on patch set 3 V +1 10/05/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47430

  12. Christian Kuhn commented on patch set 3 10/05/23, 09:55

    Feature-102067-BeforeTcaOverridesEvent.rst:49

    I think this should include a note that TCA is 'runtime cached': TCA is built exactly once, so any 'dynamic' additions must never create state from runtime state like depending on given request or similar, which may not even exist when first call is from cli for instance.
  13. Stefan Bürk voted on patch set 3 V 0 CR 0 10/05/23, 12:35

  14. Stefan Bürk commented on patch set 3 10/05/23, 12:35

    Feature-102067-BeforeTcaOverridesEvent.rst:49 Reply

    good point
  15. Oli Bartsch uploaded patch set 4 V +1 10/05/23, 14:12

  16. Oli Bartsch commented on patch set 4 V +1 CR +1 10/05/23, 14:12

    Feature-102067-BeforeTcaOverridesEvent.rst:49 Reply

    Done
  17. core-ci voted on patch set 4 V +1 10/05/23, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47444

  18. Stefan Bürk voted on patch set 4 V +2 CR +2 10/05/23, 14:19

  19. Stefan Bürk merged patch set 5 10/05/23, 14:19