81305[DOCS] Fix grammatical errors
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 128
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderPropertyManager.php+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+2 −2
- typo3/sysext/core/Classes/Database/Schema/SchemaMigrator.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+1 −1
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+1 −1
- typo3/sysext/core/Classes/Page/JavaScriptModuleInstruction.php+1 −1
- typo3/sysext/core/Classes/Resource/Exception/OnlineMediaAlreadyExistsException.php+1 −1
- typo3/sysext/core/Classes/Resource/Security/StoragePermissionsAspect.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/FileInclude.php+1 −1
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionAggregatorVisitor.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Tokenizer/Line/LineInterface.php+1 −1
- typo3/sysext/core/Documentation/Changelog/7.0/Breaking-33805-ClickMenuRewrite.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/7.2/Feature-65585-AddTCATypeImage_manipulation.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/7.3/Feature-66709-AddTemplateRootPathsSupportToFluidViewStandaloneView.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/7.4/Deprecation-67670-DeprecateCustomSingletonLogicInGeneralUtilitygetUserObj.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/7.5/Feature-56726-TriggerMetadataExtractionAfterFileUpload.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/7.5/Feature-61799-ImprovedHandlingOfOnlineMedia.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/7.5/Feature-66366-IntroducedMediaViewHelper.rst+1 −1
Show 108 more files
- typo3/sysext/core/Documentation/Changelog/8.5/Breaking-78581-HookGetFlexFormDSClassNoLongerCalled.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/8.7/Feature-80579-ImprovedJavaScriptModalAPI.rst+4 −4
- typo3/sysext/core/Documentation/Changelog/9.0/Breaking-79777-AddedDeletedColumnForSchedulerTasks.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.0/Breaking-82572-RDCTFunctionalityRemoved.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.0/Breaking-82768-ConfigurationOptionsForImageManipulationPHPAPI.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.0/Breaking-82899-MoreRestrictingChecksForAPIMethodsInExtensionManagementUtility.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.0/Deprecation-78410-DeprecatePopoverMemberInstanceInTYPO3GlobalObject.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.0/Deprecation-82899-ExtensionManagementUtilityMethods.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.3/Deprecation-85124-RedirectingUrlHandlerHookConcept.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.4/Breaking-85761-AuthenticationChainChanges.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/9.4/Deprecation-85902-IMGMENUGMENU.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/10.0/Breaking-87937-TCAOption_selicon_field_path_removed.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/10.0/Breaking-88741-CHashCalculationInIndexedSearchRemoved.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/10.4/Deprecation-90956-AlternativeFetchMethodsAndReportsForGeneralUtilitygetUrl.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/11.1/Feature-93426-SVG-basedTreeForFolderNavigationWithFilter.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/11.2/Feature-73176-FilterableTreesInRecordSelectorsAndLinkPickers.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/11.3/Deprecation-94377-ExtbaseObjectManager-getEmptyObject.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/11.4/Deprecation-94687-SoftReferenceIndex.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/11.5/Deprecation-95349-TypoScriptPageincludeCSSincludeCSSLibsimport.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/11.5.x/Important-93635-AddMailConfigurationForSettingSmtpDomain.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-90044-ConfigspamProtectEmailAddressesWithOptionAsciiRemoved.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-97797-GFXSettingProcessor_path_lzwRemoved.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98312-TypoScriptSettingPageCSS_inlineStyleRemoved.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98377-FluidStandaloneViewDoesNotCreateAnExtbaseRequestAnymore.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-98375-PSR-14EventsInPageModule.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.2/Feature-99632-IntroducePHPAttributeToMarkAWebhookMessage.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-19856-SetSpecialATagParamsForLinksToAccessRestrictedPages.rst+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_mfa_provider.xlf+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+1 −1
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/MfaProviderRegistryTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreCsv/Modify/ActionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/ActionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/ActionTest.php+1 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/Regular/AbstractActionTestCase.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/UrlLinkHandlerTest.php+1 −1
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+1 −1
- typo3/sysext/extensionmanager/Classes/Remote/TerExtensionRemote.php+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php3+1 −1
- typo3/sysext/form/Documentation/D/FinisherOptions/Index.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formEditor/Index.rst+2 −2
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/TextEditor.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/Typo3WinBrowserEditor.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/20/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/30/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/40/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/50/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/60/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/70/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/propertyCollections/validators/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/20/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/30/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/40/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/50/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/60/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/70/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Date/formEditor/propertyCollections/validators/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/DatePicker/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Email/formEditor/propertyCollections/validators/40/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/FileUpload/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/20/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/30/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/40/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/50/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/60/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/70/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Form/formEditor/propertyCollections/finishers/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/ImageUpload/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiCheckbox/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/MultiSelect/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/formEditor/propertyCollections/validators/60/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Number/formEditor/propertyCollections/validators/70/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/20/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/30/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/40/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/50/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/60/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/70/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/propertyCollections/validators/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Telephone/formEditor/propertyCollections/validators/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/20/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/30/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/40/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/50/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/60/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/propertyCollections/validators/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/10/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/20/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/30/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/40/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/50/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/60/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/70/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/propertyCollections/validators/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Url/formEditor/propertyCollections/validators/80/identifier.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/formElements/Index.rst+2 −2
- typo3/sysext/frontend/Classes/Aspect/FileMetadataOverlayAspect.php+1 −1
- typo3/sysext/indexed_search/Classes/Service/DatabaseSchemaService.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+1 −1
- typo3/sysext/lowlevel/Tests/Functional/Clean/CleanUpLocalProcessedFilesTest.php+1 −1
- typo3/sysext/rte_ckeditor/Documentation/Configuration/BestPractices.rst+1 −1
- typo3/sysext/t3editor/Resources/Private/tsref.xml+5 −5
Review log 2328
Show 23 earlier messages
-
Simon Schaufelberger uploaded patch set 1 10/01/23, 11:24
-
Simon Schaufelberger commented on patch set 1 10/01/23, 11:26
is this TASK or BUGFIX or DOCS? -
core-ci voted on patch set 1 V +1 10/01/23, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47327
-
Benjamin Franzke uploaded patch set 2
V +110/02/23, 05:46 -
Benjamin Franzke commented on patch set 2 10/02/23, 05:46
Reply
Hm, not a real BUGFIX (only one minior user-facing string is modified), so no BUGFIX. Pro DOCS: many docs changes, Contra DOCS: Not only docs changes. Anyway, we're fine with DOCS here…DataHandler.php:4015This is still wrong as that "a/an" needs to be placed after "e.g.", IMO better: "if a sys_file_reference that refers e.g. to a tt_content record" -
core-ci voted on patch set 2 V +1 10/02/23, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47331
-
Simon Schaufelberger commented on patch set 2 10/02/23, 12:21
DataHandler.php:4015ReplyDone -
Simon Schaufelberger uploaded patch set 3
CR +1V +110/02/23, 12:31 -
core-ci voted on patch set 3 V +1 10/02/23, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47349
-
Chris Müller uploaded patch set 4
V +110/02/23, 14:53 -
core-ci voted on patch set 4 V +1 10/02/23, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47353
-
Chris Müller voted on patch set 4 V +1 CR +1 10/02/23, 15:02
-
Benjamin Franzke commented on patch set 4 CR -2 10/02/23, 17:10
I don't even understand that sentence and I'm strongly against pasting anything from ChatGPT into our sources. Will block this for now. -
Simon Schaufelberger commented on patch set 4 10/02/23, 18:10
Reply
hey Benjamin, what is it that you don't understand and can you please explain WHY you block this and what I should do? it would be easier to resolve this issue if you could give me a task. -
Benjamin Franzke commented on patch set 4 10/02/23, 18:15
Reply
The "that" in the sentence "Improve code documentation that is easier to understand" makes no sense. You probably mean "to be easier to understand". But I really don't want any sentences pasted from ChatGPT in our (code) documentation. So you either rephase that code block on your own, or we revert to patchet 2. -
Simon Schaufelberger commented on patch set 4 10/02/23, 18:18
Reply
What is your problem with slight improvement of wording from ChatGPT? Surely, I can easily adjust the commit message. -
Benni Mack commented on patch set 4 10/02/23, 19:02
Reply
do we have any insights on how GPLv2 is working in terms of IP in conjunction with AI / ChatGPT? If not, I'm very much reluctant on adding AI-developed changes for the time being. -
Simon Schaufelberger uploaded patch set 5
CR +1V +110/02/23, 19:27Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Simon Schaufelberger commented on patch set 5 10/02/23, 19:29
Reply
ok, I see your point. I reverted to changeset 2. -
core-ci voted on patch set 5 V +1 10/02/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47360
-
Simon Schaufelberger commented on patch set 5 10/04/23, 12:07
Reply
Done -
Garvin Hicking commented on patch set 5 V +1 CR +1 10/11/23, 15:31
Wow, nice work on this. Curious: Did you manually do this or some automatism? If you did it with the latter, maybe it could be added to the codecheck/linting (probably needs rector-style introspection to only work on string contents, docblocks, RST files, ...). Anyhow, I read through all of it, looks good. Only the XLFF change for the OTP might force re-translation due to the change, would that be an issue?FormEditorController.php:83"Editing"? -
Simon Schaufelberger commented on patch set 5 10/11/23, 16:01
Reply
All manual search and replace. Search for: " a a", " a e", " a i" and " a o" but not for " a u" because "an user" is wrong. > XLFF yes I'm aware of it but translations should not be depending on this as it is only wrong in english ;)FormEditorController.php:83ReplyI guess there are many more places that could be improved. My personal opinion would be to do that in a different patch -
Oliver Klee voted on patch set 5 V +1 CR +1 10/11/23, 16:47
-
Garvin Hicking commented on patch set 5 10/12/23, 06:41
FormEditorController.php:83ReplyAck, that does make sense. Just stumbled across it, because it sounds off. -
Benjamin Franzke voted on patch set 5 V +1 CR +1 10/20/23, 08:06
-
Benjamin Franzke voted on patch set 5 V +2 CR +2 10/20/23, 08:12
-
Benjamin Franzke merged patch set 6 10/20/23, 08:37