Review main Merged

81305[DOCS] Fix grammatical errors

Simon Schaufelberger CR +2 V +2 Hard +139 −139 updated 10/20/23, 08:37

Commit message

Most fixes relate to indefinite article usage "an vs a" and some typos.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 128

Show 108 more files

Review log 2328

Show 23 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 10/01/23, 11:24

  2. Simon Schaufelberger commented on patch set 1 10/01/23, 11:26

    is this TASK or BUGFIX or DOCS?
  3. core-ci voted on patch set 1 V +1 10/01/23, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47327

  1. Benjamin Franzke uploaded patch set 2 V +1 10/02/23, 05:46

  2. Benjamin Franzke commented on patch set 2 10/02/23, 05:46

    Reply

    Hm, not a real BUGFIX (only one minior user-facing string is modified), so no BUGFIX. Pro DOCS: many docs changes, Contra DOCS: Not only docs changes. Anyway, we're fine with DOCS here…

    DataHandler.php:4015

    This is still wrong as that "a/an" needs to be placed after "e.g.", IMO better: "if a sys_file_reference that refers e.g. to a tt_content record"
  3. core-ci voted on patch set 2 V +1 10/02/23, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47331

  4. Simon Schaufelberger commented on patch set 2 10/02/23, 12:21

    DataHandler.php:4015 Reply

    Done
  5. Simon Schaufelberger uploaded patch set 3 CR +1 V +1 10/02/23, 12:31

  6. core-ci voted on patch set 3 V +1 10/02/23, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47349

  7. Chris Müller uploaded patch set 4 V +1 10/02/23, 14:53

  8. core-ci voted on patch set 4 V +1 10/02/23, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47353

  9. Chris Müller voted on patch set 4 V +1 CR +1 10/02/23, 15:02

  10. Benjamin Franzke commented on patch set 4 CR -2 10/02/23, 17:10

    I don't even understand that sentence and I'm strongly against pasting anything from ChatGPT into our sources. Will block this for now.
  11. Simon Schaufelberger commented on patch set 4 10/02/23, 18:10

    Reply

    hey Benjamin, what is it that you don't understand and can you please explain WHY you block this and what I should do? it would be easier to resolve this issue if you could give me a task.
  12. Benjamin Franzke commented on patch set 4 10/02/23, 18:15

    Reply

    The "that" in the sentence "Improve code documentation that is easier to understand" makes no sense. You probably mean "to be easier to understand". But I really don't want any sentences pasted from ChatGPT in our (code) documentation. So you either rephase that code block on your own, or we revert to patchet 2.
  13. Simon Schaufelberger commented on patch set 4 10/02/23, 18:18

    Reply

    What is your problem with slight improvement of wording from ChatGPT? Surely, I can easily adjust the commit message.
  14. Benni Mack commented on patch set 4 10/02/23, 19:02

    Reply

    do we have any insights on how GPLv2 is working in terms of IP in conjunction with AI / ChatGPT? If not, I'm very much reluctant on adding AI-developed changes for the time being.
  15. Simon Schaufelberger uploaded patch set 5 CR +1 V +1 10/02/23, 19:27

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  16. Simon Schaufelberger commented on patch set 5 10/02/23, 19:29

    Reply

    ok, I see your point. I reverted to changeset 2.
  17. core-ci voted on patch set 5 V +1 10/02/23, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47360

  18. Simon Schaufelberger commented on patch set 5 10/04/23, 12:07

    Reply

    Done
  19. Garvin Hicking commented on patch set 5 V +1 CR +1 10/11/23, 15:31

    Wow, nice work on this. Curious: Did you manually do this or some automatism? If you did it with the latter, maybe it could be added to the codecheck/linting (probably needs rector-style introspection to only work on string contents, docblocks, RST files, ...). Anyhow, I read through all of it, looks good. Only the XLFF change for the OTP might force re-translation due to the change, would that be an issue?

    FormEditorController.php:83

    "Editing"?
  20. Simon Schaufelberger commented on patch set 5 10/11/23, 16:01

    Reply

    All manual search and replace. Search for: " a a", " a e", " a i" and " a o" but not for " a u" because "an user" is wrong. > XLFF yes I'm aware of it but translations should not be depending on this as it is only wrong in english ;)

    FormEditorController.php:83 Reply

    I guess there are many more places that could be improved. My personal opinion would be to do that in a different patch
  21. Oliver Klee voted on patch set 5 V +1 CR +1 10/11/23, 16:47

  22. Garvin Hicking commented on patch set 5 10/12/23, 06:41

    FormEditorController.php:83 Reply

    Ack, that does make sense. Just stumbled across it, because it sounds off.
  23. Benjamin Franzke voted on patch set 5 V +1 CR +1 10/20/23, 08:06

  24. Benjamin Franzke voted on patch set 5 V +2 CR +2 10/20/23, 08:12

  25. Benjamin Franzke merged patch set 6 10/20/23, 08:37