Review main Merged

81310[BUGFIX] Allow deleting scheduler task from detail view

Garvin Hicking CR +2 V +2 Easy +18 −9 updated 10/04/23, 14:13

Commit message

The scheduler detail view offers a "delete" button to delete a
task from that view. This button now properly triggers a POST
request, which is required by the controller to actually handle
the delete action.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1315

  1. Garvin Hicking uploaded patch set 1 10/02/23, 16:07

  2. core-ci voted on patch set 1 V +1 10/02/23, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47356

  3. Torben Hansen voted on patch set 1 V +1 CR +1 10/02/23, 16:32

  4. Thomas Hohn voted on patch set 1 CR +1 10/02/23, 19:13

  5. Oli Bartsch commented on patch set 1 V -1 10/04/23, 12:39

    Deleting a Record should only happen via POST. That's the reason why we explicitly only check for parsedBody in the Controller. This means, the bug in this case is the GET request to delete the task. This must be a POST request as done in the list view. Will update the patch.
  6. Garvin Hicking commented on patch set 1 10/04/23, 12:47

    Reply

    Ah, that totally makes sense. I'm sorry for not getting that, thanks for checking.
  7. Oli Bartsch uploaded patch set 2 CR +1 V +1 10/04/23, 13:04

  8. Oli Bartsch uploaded patch set 3 10/04/23, 13:09

  9. Oli Bartsch commented on patch set 3 V +1 CR +1 10/04/23, 13:09

    Reply

    Done
  10. core-ci voted on patch set 3 V +1 10/04/23, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47401

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 10/04/23, 13:33

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 10/04/23, 14:04

  13. Torben Hansen voted on patch set 3 V +1 CR +1 10/04/23, 14:08

  14. Oli Bartsch voted on patch set 3 V +2 CR +2 10/04/23, 14:13

  15. Oli Bartsch merged patch set 4 10/04/23, 14:13