Review main Merged

81311[BUGFIX] Add CKEditor5 migrator for typo3link.additionalAttributes

Benjamin Franzke CR +2 V +2 Normal +148 −10 updated 10/06/23, 14:32

Commit message

editor.config.typo3link.additionalAttributes was used in
TYPO3 v11 to enable certian attribute on link tags.
Add a migrator that enables the same effect via the
General HTML Support (GHS) CKEditor5 plugin configuration
`config.htmlSupport`.

Also remove the evaluation of the related but unused global config option
['EXTCONF']['rte_ckeditor']['plugins']['TYPO3Link']['additionalAttributes']
which was added in #78917 (initial CKEditor4 linkbrowser integration)
but was never actually used (which was probably undiscovered due to its
similar name).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1923

  1. Benjamin Franzke uploaded patch set 1 10/02/23, 16:18

  2. core-ci voted on patch set 1 V +1 10/02/23, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47357

  3. Benjamin Franzke uploaded patch set 2 V +1 10/04/23, 11:08

  4. core-ci voted on patch set 2 V +1 10/04/23, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47390

  5. Benjamin Kott voted on patch set 2 V +1 CR +1 10/05/23, 09:17

  6. Stefan Bürk commented on patch set 2 10/06/23, 07:49

    CKEditor5Migrator.php:599

    Double assignment .. the `$additionalAttributes` assignment here is superflous - or not ?
  7. Benjamin Franzke uploaded patch set 3 CR +1 V +1 10/06/23, 08:40

  8. Benjamin Franzke commented on patch set 3 10/06/23, 08:40

    CKEditor5Migrator.php:599 Reply

    Ack
  9. Stefan Bürk voted on patch set 3 V +1 CR +1 10/06/23, 08:43

  10. core-ci voted on patch set 3 V -1 10/06/23, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47459

  11. Stefan Bürk commented on patch set 3 V 0 CR 0 10/06/23, 08:53

    needs rebase to have the DateFormatter fix as base for PHP8.3.0RC3 ....
  12. Benjamin Franzke rebased onto patch set 4 V -1 10/06/23, 08:55

    Rebase
  13. core-ci voted on patch set 4 V +1 10/06/23, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47464

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 10/06/23, 09:10

  15. Oliver Hader voted on patch set 4 CR +1 10/06/23, 10:04

  16. Oliver Hader voted on patch set 4 V +1 10/06/23, 10:18

  17. Oliver Hader commented on patch set 4 10/06/23, 10:19

    CKEditor5Migrator.php:593

    Thus, there must be other settings for `typo3link`, otherwise `additionalAttributes` is completely skipped? I could not find any references for that...
  18. Benjamin Franzke commented on patch set 4 10/06/23, 10:21

    CKEditor5Migrator.php:593 Reply

    Me neither. I only found editor.config.typo3link.additionalAttributes. I'd actually remove this setting in v13. Fine?
  19. Oliver Hader commented on patch set 4 10/06/23, 12:19

    CKEditor5Migrator.php:593 Reply

    Fine more me...
  20. Oli Bartsch voted on patch set 4 V +1 CR +1 10/06/23, 12:54

  21. Benjamin Franzke voted on patch set 4 V +2 CR +2 10/06/23, 13:00

  22. Benjamin Franzke merged patch set 5 10/06/23, 13:00

  23. Oliver Hader commented on patch set 5 10/06/23, 14:32

    CKEditor5Migrator.php:593 Reply

    Done