81311[BUGFIX] Add CKEditor5 migrator for typo3link.additionalAttributes
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
- Oliver Hader +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Stefan Bürk +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/rte_ckeditor/plugin/typo3-link.ts+0 −1
- typo3/sysext/core/Classes/Configuration/CKEditor5Migrator.php6+20 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96874-CKEditor5.rst+1 −0
- typo3/sysext/core/Tests/Unit/Configuration/CKEditor5MigratorTest.php+127 −0
- typo3/sysext/rte_ckeditor/Classes/Controller/BrowseLinksController.php+0 −9
Review log 1923
-
Benjamin Franzke uploaded patch set 1 10/02/23, 16:18
-
core-ci voted on patch set 1 V +1 10/02/23, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47357
-
Benjamin Franzke uploaded patch set 2
V +110/04/23, 11:08 -
core-ci voted on patch set 2 V +1 10/04/23, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47390
-
Benjamin Kott voted on patch set 2 V +1 CR +1 10/05/23, 09:17
-
Stefan Bürk commented on patch set 2 10/06/23, 07:49
-
Benjamin Franzke uploaded patch set 3
CR +1V +110/06/23, 08:40 -
Benjamin Franzke commented on patch set 3 10/06/23, 08:40
CKEditor5Migrator.php:599ReplyAck -
Stefan Bürk voted on patch set 3 V +1 CR +1 10/06/23, 08:43
-
core-ci voted on patch set 3 V -1 10/06/23, 08:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47459
-
Stefan Bürk commented on patch set 3 V 0 CR 0 10/06/23, 08:53
needs rebase to have the DateFormatter fix as base for PHP8.3.0RC3 .... -
Benjamin Franzke rebased onto patch set 4
V -110/06/23, 08:55Rebase -
core-ci voted on patch set 4 V +1 10/06/23, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47464
-
Stefan Bürk voted on patch set 4 V +1 CR +1 10/06/23, 09:10
-
Oliver Hader voted on patch set 4 CR +1 10/06/23, 10:04
-
Oliver Hader voted on patch set 4 V +1 10/06/23, 10:18
-
Oliver Hader commented on patch set 4 10/06/23, 10:19
CKEditor5Migrator.php:593Thus, there must be other settings for `typo3link`, otherwise `additionalAttributes` is completely skipped? I could not find any references for that... -
Benjamin Franzke commented on patch set 4 10/06/23, 10:21
CKEditor5Migrator.php:593ReplyMe neither. I only found editor.config.typo3link.additionalAttributes. I'd actually remove this setting in v13. Fine? -
Oliver Hader commented on patch set 4 10/06/23, 12:19
CKEditor5Migrator.php:593ReplyFine more me... -
Oli Bartsch voted on patch set 4 V +1 CR +1 10/06/23, 12:54
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 10/06/23, 13:00
-
Benjamin Franzke merged patch set 5 10/06/23, 13:00
-
Oliver Hader commented on patch set 5 10/06/23, 14:32
CKEditor5Migrator.php:593ReplyDone
CKEditor5Migrator.php:599