Review main Merged

81323[TASK] Unbundle CKEditor5

Benjamin Franzke CR +2 V +2 Impossible +3213 −97344 updated 10/07/23, 05:15

Commit message

Unbundle CKEditor5 in order to be able to load plugins like "font" only
if actually configured, allowing TYPO3 core to ship *all* available
ckeditor5 modules without having to weigh in the downsides for large
modules that we do not want to ship for "every" installation.

All @ckeditor scoped npm packages provided by CKEditor5 are bundled into
an own small per-package bundle that is loaded (and linked to each
other) via our importmap infrastructure. This allows specific modules to
be loaded ondemand and has the additional advantage that plugin authors
can use modules via packages exports as suggested by upstream
documentation. This should lower the the barrier for writing custom
plugins.

The existing bundle @typo3/ckeditor5-bundle is still in
place and acts as wrapper for the split bundles. It is
deprecated and will be removed in TYPO3 v13.0.

Also worth noting is that terser is now used to
shrink the module size.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 69

Show 49 more files

Review log 1830

Show 35 earlier messages
  1. Benjamin Franzke uploaded patch set 1 10/05/23, 05:59

  2. core-ci voted on patch set 1 V -1 10/05/23, 06:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47415

  3. Benjamin Franzke uploaded patch set 2 V -1 10/05/23, 07:30

  4. core-ci voted on patch set 2 V -1 10/05/23, 07:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47419

  5. Benjamin Franzke uploaded patch set 3 V -1 10/05/23, 08:47

  1. core-ci voted on patch set 3 V -1 10/05/23, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47426

  2. Benjamin Franzke uploaded patch set 4 V -1 10/05/23, 10:51

  3. core-ci voted on patch set 4 V -1 10/05/23, 11:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47435

  4. Benjamin Franzke uploaded patch set 5 V -1 10/06/23, 08:10

  5. core-ci voted on patch set 5 V -1 10/06/23, 08:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47456

  6. Benjamin Franzke uploaded patch set 6 V -1 10/06/23, 08:50

  7. core-ci voted on patch set 6 V -1 10/06/23, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47462

  8. Benjamin Franzke uploaded patch set 7 V -1 10/06/23, 09:05

  9. Benjamin Franzke updated the commit message in patch set 8 10/06/23, 09:08

  10. core-ci voted on patch set 8 V -1 10/06/23, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47471

  11. Benjamin Franzke uploaded patch set 9 V -1 10/06/23, 11:51

  12. core-ci voted on patch set 9 V +1 10/06/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47482

  13. Benjamin Franzke uploaded patch set 10 V +1 10/06/23, 12:30

  14. core-ci voted on patch set 10 V +1 10/06/23, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47489

  15. Benjamin Franzke uploaded patch set 11 V +1 10/06/23, 14:35

  16. core-ci voted on patch set 11 V -1 10/06/23, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47503

  17. Benjamin Franzke uploaded patch set 12 V -1 10/06/23, 14:48

    Rebase
  18. core-ci voted on patch set 12 V +1 10/06/23, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47506

  19. Benjamin Kott commented on patch set 12 CR -1 10/06/23, 15:13

    custom plugins are not loaded, whitespace and link plugins are not loaded.
  20. Benjamin Franzke uploaded patch set 13 CR -1 V +1 10/06/23, 15:21

  21. core-ci voted on patch set 13 V +1 10/06/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47511

  22. Benjamin Kott voted on patch set 13 V +1 CR +1 10/06/23, 15:35

  23. Stefan Bürk voted on patch set 13 V +1 CR +1 10/06/23, 18:27

  24. Benjamin Franzke voted on patch set 13 V +2 CR +2 10/07/23, 04:38

  25. Benjamin Franzke merged patch set 14 10/07/23, 05:15