81329[TASK] Aria-describedby for password field
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Torben Hansen +1
-
Verified V +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1419
-
Patrick Schriner uploaded patch set 1 10/06/23, 09:06
-
Patrick Schriner uploaded patch set 2 10/06/23, 09:17
-
core-ci voted on patch set 1 V -1 10/06/23, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47469
-
Chris Müller updated the commit message in patch set 3 10/06/23, 09:21
-
core-ci voted on patch set 2 V +1 10/06/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47473
-
core-ci voted on patch set 3 V +1 10/06/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47475
-
Oli Bartsch commented on patch set 3 V -1 10/06/23, 13:15
String concatenation seems to be broken. Applying the patch leads to following HTML: <input id="field_password" type="password aria-describedby=" description_password"="" "="" name="data[be_users][password]" autocomplete="new-password" value="" class=" form-control"> Additionally, the id attribute on the p-tag contains a trailing whitespace. Also the whole description would IMO include the listing, so you might want to add a div container around the <p> and the <ul>. -
Patrick Schriner uploaded patch set 4
V +110/06/23, 14:05 -
core-ci voted on patch set 4 V +1 10/06/23, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47500
-
Patrick Schriner commented on patch set 4 10/06/23, 15:36
Reply
jep, I've got a special hatred for this intermixed building of HTML in the backend - should be solved now. Added a div as well -
Christian Kuhn commented on patch set 4 10/06/23, 16:19
Reply
yeah. i hope at some point we'll finally manage to transition 'user settings' to 'fake tca' to use formengine for rendering. this is on my list for a looong time already ... -
Christian Kuhn voted on patch set 4 V +1 CR +1 10/06/23, 16:21
-
Christian Kuhn updated the commit message in patch set 5
CR +1V +110/06/23, 16:23 -
Christian Kuhn voted on patch set 5 V +1 CR +1 10/06/23, 16:23
-
Christian Kuhn commented on patch set 5 10/06/23, 16:25
Reply
ping me if you're interested in working on this. -
core-ci voted on patch set 5 V +1 10/06/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47516
-
Torben Hansen voted on patch set 5 V +1 CR +1 10/06/23, 16:36
-
Christian Kuhn voted on patch set 5 V +2 CR +2 10/06/23, 16:49
-
Christian Kuhn merged patch set 6 10/06/23, 16:49