Review main Merged

81329[TASK] Aria-describedby for password field

Patrick Schriner CR +2 V +2 Easy +12 −5 updated 10/06/23, 16:49

Commit message

Add a aria-describedby attribute to link the password field with the
requirements description.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1419

  1. Patrick Schriner uploaded patch set 1 10/06/23, 09:06

  2. Patrick Schriner uploaded patch set 2 10/06/23, 09:17

  3. core-ci voted on patch set 1 V -1 10/06/23, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47469

  4. Chris Müller updated the commit message in patch set 3 10/06/23, 09:21

  5. core-ci voted on patch set 2 V +1 10/06/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47473

  6. core-ci voted on patch set 3 V +1 10/06/23, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47475

  7. Oli Bartsch commented on patch set 3 V -1 10/06/23, 13:15

    String concatenation seems to be broken. Applying the patch leads to following HTML: <input id="field_password" type="password aria-describedby=" description_password"="" "="" name="data[be_users][password]" autocomplete="new-password" value="" class=" form-control"> Additionally, the id attribute on the p-tag contains a trailing whitespace. Also the whole description would IMO include the listing, so you might want to add a div container around the <p> and the <ul>.
  8. Patrick Schriner uploaded patch set 4 V +1 10/06/23, 14:05

  9. core-ci voted on patch set 4 V +1 10/06/23, 14:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47500

  10. Patrick Schriner commented on patch set 4 10/06/23, 15:36

    Reply

    jep, I've got a special hatred for this intermixed building of HTML in the backend - should be solved now. Added a div as well
  11. Christian Kuhn commented on patch set 4 10/06/23, 16:19

    Reply

    yeah. i hope at some point we'll finally manage to transition 'user settings' to 'fake tca' to use formengine for rendering. this is on my list for a looong time already ...
  12. Christian Kuhn voted on patch set 4 V +1 CR +1 10/06/23, 16:21

  13. Christian Kuhn updated the commit message in patch set 5 CR +1 V +1 10/06/23, 16:23

  14. Christian Kuhn voted on patch set 5 V +1 CR +1 10/06/23, 16:23

  15. Christian Kuhn commented on patch set 5 10/06/23, 16:25

    Reply

    ping me if you're interested in working on this.
  16. core-ci voted on patch set 5 V +1 10/06/23, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47516

  17. Torben Hansen voted on patch set 5 V +1 CR +1 10/06/23, 16:36

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 10/06/23, 16:49

  19. Christian Kuhn merged patch set 6 10/06/23, 16:49