Review main Merged

81344[BUGFIX] Revert "[BUGFIX] Enable configuration passthrough for custom CKEditor5 plugins"

Oliver Hader CR +2 V +2 Hard +147 −130 updated 10/10/23, 10:19

Commit message

This reverts commit bd5a93e1c7576b40de34025b8195c2ca844eaf88.

Due to a changed handling of `extraPlugins`, the editor config of e.g.
ext:bootstrap_package v14.0.7 cannot be used anymore.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Oliver Hader uploaded patch set 1 10/10/23, 09:43

  2. Oliver Hader updated the commit message in patch set 2 10/10/23, 09:45

  3. core-ci voted on patch set 1 V +1 10/10/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47645

  4. Benjamin Franzke voted on patch set 2 V +1 CR +1 10/10/23, 09:56

  5. core-ci voted on patch set 2 V +1 10/10/23, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47647

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/10/23, 10:14

  7. Oliver Hader voted on patch set 2 V +2 CR +2 10/10/23, 10:19

  8. Oliver Hader merged patch set 3 10/10/23, 10:19