Review 12.4 Abandoned

81345[BUGFIX] Revert "[BUGFIX] Enable configuration passthrough for custom CKEditor5 plugins"

Oliver Hader CR 0 V 0 Hard +147 −130 updated 10/10/23, 10:12

Commit message

This reverts commit 32fb9912444d09ddd8dbb0a1423d30dc9e568c56.

Due to a changed handling of `extraPlugins`, the editor config of e.g.
ext:bootstrap_package v14.0.7 cannot be used anymore.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 45

  1. Oliver Hader uploaded patch set 1 10/10/23, 09:44

  2. core-ci voted on patch set 1 V +1 10/10/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47646

  3. Benjamin Franzke commented on patch set 1 10/10/23, 09:58

    should ideally be I5d36a9ab0e309833a015fcd5f3221670dc114f06 to match the main changeid (required for the backports checker)
  4. Oliver Hader abandoned the change 10/10/23, 10:12

    For the Change-ID thing, I have to abandon this change in favor of the new one https://review.typo3.org/c/Packages/TYPO3.CMS/+/81400
  5. Oliver Hader commented on patch set 1 10/10/23, 10:12

    Reply

    Yes. Gerrit did that, since I was using the UI...