81352[TASK] Warn about empty @import in TypoScript
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 5
Files 15
- typo3/sysext/backend/Resources/Private/Language/locallang_pagetsconfig.xlf+3 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeSyntaxScannerVisitor.php+90 −8
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-97816-TypoScriptSyntaxImprovements.rst+6 −6
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validImportA.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validImportB1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validImportB2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validImportC.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validImportD1.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validImportD2.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validIncludeTypoScriptA.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/Imports/validIncludeTypoScriptB.typoscriptnew+1 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/includes.typoscript3new+16 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Fixtures/IncludeTreeSyntaxScannerVisitor/RootTemplate.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/Visitor/IncludeTreeSyntaxScannerVisitorTest.php+33 −8
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_analyzer.xlf+3 −0
Review log 1520
-
Christian Kuhn uploaded patch set 1 10/06/23, 09:37
-
Christian Kuhn commented on patch set 1 10/06/23, 09:39
needs @todo comments that the include tree is not good with import statements (we should always create child nodes for each import statement, even if it does not resolve). This is a bit fiddly though and may not be backported to v12 anymore. we should cover this visitor with good functional tests to verify the detection does not break again when we refactor the include tree. -
core-ci voted on patch set 1 V -1 10/06/23, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47476
-
Christian Kuhn rebased onto patch set 2
V -110/06/23, 09:51 -
core-ci voted on patch set 2 V -1 10/06/23, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47479
-
Christian Kuhn uploaded patch set 3
V -110/06/23, 11:58 -
core-ci voted on patch set 3 V +1 10/06/23, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47485
-
Christian Kuhn commented on patch set 3 10/06/23, 12:10
Reply
Done -
Markus Klein commented on patch set 3 10/06/23, 12:46
includes.typoscript:4maybe we should add `@import './ImportsFullDir/' -
Christian Kuhn commented on patch set 3 10/06/23, 12:51
includes.typoscript:4Replyi stayed away from this: this test is about finding invalid imports, not about @import syntax details, which have own tests. -
Christian Kuhn commented on patch set 3 10/06/23, 12:54
includes.typoscript:4Replyok, does not matter much. i'll add it. -
Christian Kuhn uploaded patch set 4
V +110/06/23, 12:55 -
Christian Kuhn uploaded patch set 5 10/06/23, 13:05
-
core-ci voted on patch set 4 V +1 10/06/23, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47492
-
Markus Klein voted on patch set 5 V +1 CR +1 10/06/23, 13:07
-
core-ci voted on patch set 5 V +1 10/06/23, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47494
-
Stefan Bürk voted on patch set 5 V +1 CR +1 10/06/23, 13:13
-
Christian Kuhn voted on patch set 5 V +2 CR +2 10/06/23, 13:40
-
Christian Kuhn merged patch set 6 10/06/23, 13:40
-
Oli Bartsch voted on patch set 5 V +1 CR +1 10/06/23, 13:42