Review 12.4 Merged

81358[TASK] Warn about empty @import in TypoScript

Christian Kuhn CR +2 V +2 Normal +165 −22 updated 10/06/23, 13:40

Commit message

When @import or <INCLUDE_TYPOSCRIPT: lines do not
resolve to any include, this probably indicates
a broken import statement.

To help integrators find and fix those, the
Page TSconfig and TypoScript backend modules now
list them as "Syntax scanner warnings".

We're adding a functional test to verify the detection
works. This will ensure it does not break when we refactor
some details of the include tree structure later. Doing as
described in #102102 and #102103 would simplify and
streamline various details, but it's currently unclear if
we should still do this in v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 5

Files 15

Review log 34

  1. Christian Kuhn uploaded patch set 1 10/06/23, 13:25

  2. core-ci voted on patch set 1 V +1 10/06/23, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47497

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/06/23, 13:40

  4. Christian Kuhn merged patch set 2 10/06/23, 13:40