Review main Merged

81363[BUGFIX] Reduce memory usage in SysLogSerializationUpdate

Christian Kuhn CR +2 V +2 Easy +9 −13 updated 10/06/23, 16:43

Commit message

Upgrade wizard SysLogSerializationUpdate loads all
to-update rows into an array to iterate and update
one-by-one afterwards.

This can hit PHP memory limits when many rows need
to be handled.

The patch fixes this by avoiding the load to array
and iterating single result rows directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/06/23, 16:12

  2. Christian Kuhn updated the commit message in patch set 2 10/06/23, 16:14

  3. core-ci voted on patch set 1 V +1 10/06/23, 16:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47512

  4. core-ci voted on patch set 2 V +1 10/06/23, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47513

  5. Oliver Klee voted on patch set 2 V +1 CR +1 10/06/23, 16:28

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/06/23, 16:31

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/06/23, 16:43

  8. Christian Kuhn merged patch set 3 10/06/23, 16:43