Review main Merged

81366[FEATURE] Auto DB fields from TCA for type "color"

Christian Kuhn CR +2 V +2 Normal +80 −0 updated 10/06/23, 18:37

Commit message

Tables with TCA columns set to type="color" do not
need an ext_tables.sql entry anymore. The core now
creates this field automatically.

This is one of many patches in this area: The v13 goal
is to obsolete ext_tables.sql in most cases by
creating default "business" fields of TCA tables
automatically.

The patch adds the main magic in class DefaultTcaSchema
and removes own ext_tables.sql definitions having
type=color.

Note the field length is for now set to varchar(7),
which should be enough to include a hex color
definition like "#123456". This should be fine, but
could easily extended in case we missed something.

There are no direct core usages of type=color, but
ext:styleguide confirms this change should be ok.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Christian Kuhn uploaded patch set 1 10/06/23, 17:40

  2. Christian Kuhn updated the commit message in patch set 2 10/06/23, 17:44

  3. core-ci voted on patch set 1 V +1 10/06/23, 17:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47519

  4. core-ci voted on patch set 2 V +1 10/06/23, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47520

  5. Stefan Bürk updated the commit message in patch set 3 V +1 10/06/23, 18:19

  6. Stefan Bürk voted on patch set 3 V +1 CR +1 10/06/23, 18:20

  7. core-ci voted on patch set 3 V +1 10/06/23, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47521

  8. Andreas Nedbal voted on patch set 3 V +1 CR +1 10/06/23, 18:36

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 10/06/23, 18:37

  10. Christian Kuhn merged patch set 4 10/06/23, 18:37