Review main Merged

81374[TASK] Migrate getAccessibleMockForAbstractClass for EXT:form controller

Oliver Klee CR +2 V +2 Normal +38 −16 updated 10/15/23, 13:54

Commit message

`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1:
https://github.com/sebastianbergmann/phpunit/issues/5241

Hence, we should replace its usages to follow best practices and
avoid deprecation warnings later with PHPUnit 11.

We do this by creating dedicated fixture subclasses of the affected
abstract classes.

This change also cleans up the affected test to better match the
setup/execute/verify structure.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 811

  1. Oliver Klee uploaded patch set 1 10/08/23, 09:38

  2. Oliver Klee updated the commit message in patch set 2 10/08/23, 09:39

  3. core-ci voted on patch set 1 V +1 10/08/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47556

  4. core-ci voted on patch set 2 V +1 10/08/23, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47557

  5. Oliver Klee rebased onto patch set 3 V +1 10/11/23, 11:53

  6. core-ci voted on patch set 3 V +1 10/11/23, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47677

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 10/15/23, 11:41

  8. Oliver Klee voted on patch set 3 V +1 CR +1 10/15/23, 11:46

  9. Oliver Klee voted on patch set 3 V 0 CR 0 10/15/23, 11:46

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 10/15/23, 13:45

  11. Stefan Bürk merged patch set 4 10/15/23, 13:54