Review main Merged

81381[BUGFIX] Enable configuration passthrough for custom CKEditor5 plugins

Benjamin Franzke CR +2 V +2 Hard +130 −147 updated 10/10/23, 09:43

Commit message

Use JavaScript object destructuring to "remove" all options from the
configuration object, that are consumed by our CKEditor5 wrapper.
Also cleanup RTE resource and config handling to not write
unused options into the configuration array and to avoid resolving
legacy (CKEditor4) resource paths which are dropped anyway.

As a drive-by, dots are now substituted with '_' in RTE field IDs to
avoid the following hassle:
Dots are interpreted as CSS classes when the ID value is used
in combination with a number sign (#) to create a CSS selector
for the respective field ID. That means the selector will not match.
The class selector additionally becomes invalid once there is a digit
after the dot, as CSS classes need to start with strings.
(Example: EXT:styleguide in_flex » tab » rte.2).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 810

  1. Benjamin Franzke uploaded patch set 1 10/09/23, 05:04

  2. core-ci voted on patch set 1 V -1 10/09/23, 05:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47585

  3. Benjamin Franzke uploaded patch set 2 V -1 10/09/23, 05:17

  4. core-ci voted on patch set 2 V +1 10/09/23, 05:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47586

  5. Benni Mack voted on patch set 2 V +1 CR +1 10/09/23, 13:14

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/09/23, 22:01

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/10/23, 04:54

  8. Benjamin Franzke commented on patch set 2 10/10/23, 04:55

    Will resolve nightlies before merging.
  9. Benjamin Franzke merged patch set 3 10/10/23, 05:26

  10. Oliver Hader wrote 10/10/23, 09:43

    Created a revert of this change as I5d36a9ab0e309833a015fcd5f3221670dc114f06