Review main Merged

81383[DOCS] Document usage of "htmlSupport" option in EXT:rte_ckeditor

Chris Müller CR +2 V +2 Normal +51 −11 updated 10/09/23, 17:02

Commit message

Additionally:
- Use "page TSconfig" over "Page TSconfig"
- Add captions to make clearer where to store the configuration as an example

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Chris Müller uploaded patch set 1 10/09/23, 13:51

  2. core-ci voted on patch set 1 V +1 10/09/23, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47595

  3. Benjamin Franzke commented on patch set 1 10/09/23, 15:34

    Examples.rst:143

    Not wrong, as tags from foreign namespace would also not be allowed, but as this is about custom elements the separator needs to be a dash: `<my-element>`
  4. Benjamin Franzke commented on patch set 2 V +1 10/09/23, 15:35

    Published edit on patch set 1.
  5. Benjamin Franzke commented on patch set 2 V +1 CR +1 10/09/23, 15:35

    Examples.rst:143 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/09/23, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47601

  7. Chris Müller commented on patch set 2 10/09/23, 16:06

    Examples.rst:143 Reply

    Argh, I meant that. Thanks for correcting :-)
  8. Torben Hansen voted on patch set 2 V +1 CR +1 10/09/23, 16:38

  9. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/09/23, 16:51

  10. Benjamin Franzke merged patch set 3 10/09/23, 17:02