Review main Merged

81406[BUGFIX] Enable configuration passthrough for custom CKEditor5 plugins

Benjamin Franzke CR +2 V +2 Hard +137 −147 updated 11/04/23, 09:58

Commit message

Use JavaScript object destructuring to "remove" all options from the
configuration object, that are consumed by our CKEditor5 wrapper.
Also cleanup RTE resource and config handling to not write
unused options into the configuration array and to avoid resolving
legacy (CKEditor4) resource paths which are dropped anyway.

As a drive-by, dots are now substituted with '_' in RTE field IDs to
avoid the following hassle:
Dots are interpreted as CSS classes when the ID value is used
in combination with a number sign (#) to create a CSS selector
for the respective field ID. That means the selector will not match.
The class selector additionally becomes invalid once there is a digit
after the dot, as CSS classes need to start with strings.
(Example: EXT:styleguide in_flex » tab » rte.2).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 810

  1. Benjamin Franzke uploaded patch set 1 10/10/23, 16:24

    Repush original commit
  2. Benjamin Franzke uploaded patch set 2 10/10/23, 16:26

    Fix issue with bootstrap package
  3. core-ci voted on patch set 1 V +1 10/10/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47656

  4. core-ci voted on patch set 2 V +1 10/10/23, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47657

  5. Andreas Kienast voted on patch set 2 CR +1 10/17/23, 10:31

  6. Benni Mack voted on patch set 2 CR +1 11/03/23, 11:57

  7. Benni Mack voted on patch set 2 V +1 11/03/23, 12:02

  8. Oliver Hader voted on patch set 2 V +1 CR +1 11/03/23, 12:29

  9. Benjamin Franzke voted on patch set 2 V +2 CR +2 11/04/23, 09:58

  10. Benjamin Franzke merged patch set 3 11/04/23, 09:58