Review main Merged

81411[FEATURE] Modernize tree rendering and implement RTL and dark mode

Benjamin Kott CR +2 V +2 Nightmare +4698 −5208 updated 02/07/24, 14:17

Commit message

The SVG based renderer for the page, file and select trees has been
replaced by a HTML based one. It uses reactive rendering based on
lit's component model.

Using HTML and CSS rendering offers more flexibility than SVG,
so that RTL and dark mode support could now be implemented.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Frank Nägler +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 5

Files 155

Show 135 more files

Review log 109202

Show 91177 earlier messages
  1. Benjamin Kott uploaded patch set 1 10/11/23, 13:08

  2. core-ci voted on patch set 1 V -1 10/11/23, 13:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47682

  3. Benjamin Kott rebased onto patch set 2 V -1 10/16/23, 06:18

  4. core-ci voted on patch set 2 V -1 10/16/23, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47803

  5. Benjamin Kott uploaded patch set 3 V -1 10/16/23, 14:37

  6. core-ci voted on patch set 3 V -1 10/16/23, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47827

  7. Benjamin Kott uploaded patch set 4 V -1 10/17/23, 14:32

  8. Benjamin Kott uploaded patch set 5 10/17/23, 14:38

  9. Benjamin Kott rebased onto patch set 6 10/17/23, 14:40

  10. core-ci voted on patch set 4 V -1 10/17/23, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47874

  11. core-ci voted on patch set 5 V -1 10/17/23, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47876

  12. core-ci voted on patch set 6 V -1 10/17/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47877

  13. Benjamin Kott uploaded patch set 7 V -1 10/18/23, 14:19

  14. core-ci voted on patch set 7 V -1 10/18/23, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47912

  15. Benjamin Kott uploaded patch set 8 V -1 10/24/23, 14:26

  16. core-ci voted on patch set 8 V -1 10/24/23, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48128

  17. Benjamin Kott uploaded patch set 9 V -1 10/26/23, 09:54

  18. core-ci voted on patch set 9 V -1 10/26/23, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48217

  19. Benjamin Kott uploaded patch set 10 V -1 10/27/23, 11:49

  20. core-ci voted on patch set 10 V -1 10/27/23, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48288

  21. Benjamin Kott uploaded patch set 11 V -1 10/27/23, 12:16

  22. core-ci voted on patch set 11 V -1 10/27/23, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48289

  23. Benjamin Kott uploaded patch set 12 V -1 11/07/23, 08:40

  24. core-ci voted on patch set 12 V -1 11/07/23, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48678

  25. Benjamin Kott uploaded patch set 13 V -1 11/21/23, 07:37

  26. core-ci voted on patch set 13 V -1 11/21/23, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49195

  27. Benjamin Kott uploaded patch set 14 V -1 11/22/23, 10:43

  28. core-ci voted on patch set 14 V -1 11/22/23, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49334

  29. Benjamin Kott uploaded patch set 15 V -1 11/24/23, 11:55

  30. core-ci voted on patch set 15 V -1 11/24/23, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49889

  31. Benjamin Kott uploaded patch set 16 V -1 11/24/23, 14:07

  32. core-ci voted on patch set 16 V -1 11/24/23, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49894

  33. Benjamin Kott uploaded patch set 17 V -1 12/04/23, 10:07

  34. core-ci voted on patch set 17 V -1 12/04/23, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50310

  35. Benjamin Kott uploaded patch set 18 V -1 12/04/23, 10:37

  36. core-ci voted on patch set 18 V -1 12/04/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50315

  37. Benjamin Kott uploaded patch set 19 V -1 12/04/23, 13:54

  38. core-ci voted on patch set 19 V -1 12/04/23, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50320

  39. Benjamin Kott uploaded patch set 20 V -1 12/04/23, 14:20

  40. core-ci voted on patch set 20 V -1 12/04/23, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50321

  41. Benjamin Kott uploaded patch set 21 V -1 12/05/23, 12:16

  42. core-ci voted on patch set 21 V -1 12/05/23, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50368

  43. Benjamin Kott uploaded patch set 22 V -1 12/05/23, 14:13

  44. core-ci voted on patch set 22 V -1 12/05/23, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50375

  45. Benjamin Kott uploaded patch set 23 V -1 12/05/23, 14:42

  46. core-ci voted on patch set 23 V -1 12/05/23, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50379

  47. Benjamin Kott uploaded patch set 24 V -1 12/13/23, 07:31

  48. core-ci voted on patch set 24 V -1 12/13/23, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50614

  49. Benjamin Kott uploaded patch set 25 V -1 12/13/23, 08:58

  50. Benjamin Kott uploaded patch set 26 12/13/23, 09:04

  51. core-ci voted on patch set 25 V -1 12/13/23, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50616

  52. core-ci voted on patch set 26 V -1 12/13/23, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50617

  53. Benjamin Kott uploaded patch set 27 V -1 12/14/23, 07:46

  54. core-ci voted on patch set 27 V -1 12/14/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50634

  55. Benjamin Kott uploaded patch set 28 V -1 12/14/23, 10:37

  56. core-ci voted on patch set 28 V -1 12/14/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50647

  57. Benjamin Kott uploaded patch set 29 V -1 12/14/23, 11:55

  58. core-ci voted on patch set 29 V -1 12/14/23, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50653

  59. Benjamin Kott uploaded patch set 30 V -1 12/14/23, 14:50

  60. core-ci voted on patch set 30 V -1 12/14/23, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50656

  61. Benjamin Kott uploaded patch set 31 V -1 12/15/23, 08:12

  62. core-ci voted on patch set 31 V -1 12/15/23, 08:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50668

  63. Benjamin Kott uploaded patch set 32 V -1 12/15/23, 08:30

  64. core-ci voted on patch set 32 V -1 12/15/23, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50670

  65. Benjamin Kott uploaded patch set 33 V -1 12/15/23, 08:54

  66. core-ci voted on patch set 33 V -1 12/15/23, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50671

  67. Benjamin Kott uploaded patch set 34 V -1 12/15/23, 10:41

  68. core-ci voted on patch set 34 V -1 12/15/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50677

  69. Benjamin Kott uploaded patch set 35 V -1 12/15/23, 11:24

  70. core-ci voted on patch set 35 V -1 12/15/23, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50683

  71. Benjamin Kott uploaded patch set 36 V -1 01/10/24, 08:24

  72. core-ci voted on patch set 36 V -1 01/10/24, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51374

  73. Benjamin Franzke uploaded patch set 37 V -1 01/11/24, 11:32

  74. core-ci voted on patch set 37 V -1 01/11/24, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51438

  75. Benjamin Kott uploaded patch set 38 V -1 01/12/24, 08:00

  76. core-ci voted on patch set 38 V -1 01/12/24, 08:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51480

  77. Benjamin Kott uploaded patch set 39 V -1 01/17/24, 14:54

  78. core-ci voted on patch set 39 V -1 01/17/24, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51695

  79. Benjamin Kott uploaded patch set 40 V -1 01/22/24, 07:56

  80. core-ci voted on patch set 40 V -1 01/22/24, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51916

  81. Benjamin Kott uploaded patch set 41 V -1 01/25/24, 08:05

  82. core-ci voted on patch set 41 V -1 01/25/24, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52134

  83. Benjamin Kott uploaded patch set 42 V -1 01/26/24, 10:28

  84. core-ci voted on patch set 42 V -1 01/26/24, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52228

  85. Benjamin Kott uploaded patch set 43 V -1 01/26/24, 14:10

  86. core-ci voted on patch set 43 V -1 01/26/24, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52260

  87. Benjamin Kott uploaded patch set 44 V -1 01/26/24, 15:04

  88. core-ci voted on patch set 44 V -1 01/26/24, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52261

  89. Christian Kuhn commented on patch set 44 01/26/24, 16:09

    SelectTreeItem.php:20

    final? the others as well? readonly? and have a __construct for data values?

    TreeItem.php:20

    abstract?
  90. Benjamin Franzke uploaded patch set 45 V -1 01/27/24, 18:10

  91. core-ci voted on patch set 45 V -1 01/27/24, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52311

  92. Benjamin Franzke uploaded patch set 46 V -1 01/27/24, 18:50

    CGL fixes
  93. core-ci voted on patch set 46 V -1 01/27/24, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52316

  94. Benjamin Franzke uploaded patch set 47 V -1 01/27/24, 19:22

    Cleanup expanded-tree export removal
  95. core-ci voted on patch set 47 V -1 01/27/24, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52321

  96. Benjamin Franzke uploaded patch set 48 V -1 01/28/24, 19:34

    Fix context menu
  97. core-ci voted on patch set 48 V -1 01/28/24, 19:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52385

  98. Benni Mack uploaded patch set 49 V -1 01/28/24, 20:13

  99. core-ci voted on patch set 49 V -1 01/28/24, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52388

  100. Benjamin Franzke uploaded patch set 50 V -1 01/28/24, 21:20

    Fix non-drag acceptance tests
  101. core-ci voted on patch set 50 V -1 01/28/24, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52391

  102. Benjamin Kott uploaded patch set 51 V -1 01/29/24, 08:40

  103. core-ci voted on patch set 51 V -1 01/29/24, 08:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52398

  104. Benjamin Kott uploaded patch set 52 V -1 01/29/24, 10:01

  105. core-ci voted on patch set 52 V -1 01/29/24, 10:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52399

  106. Benni Mack rebased onto patch set 53 V -1 01/29/24, 10:24

  107. core-ci voted on patch set 53 V -1 01/29/24, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52400

  108. Benjamin Kott uploaded patch set 54 V -1 01/29/24, 10:49

  109. core-ci voted on patch set 54 V -1 01/29/24, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52402

  110. Benjamin Franzke uploaded patch set 55 V -1 01/29/24, 11:36

    Drop DragDropInstance
  111. core-ci voted on patch set 55 V -1 01/29/24, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52405

  112. Benjamin Franzke uploaded patch set 56 V -1 01/29/24, 14:27

  113. core-ci voted on patch set 56 V -1 01/29/24, 14:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52425

  114. Benjamin Kott uploaded patch set 57 V -1 01/29/24, 14:37

  115. core-ci voted on patch set 57 V -1 01/29/24, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52427

  116. Benjamin Kott uploaded patch set 58 V -1 01/29/24, 15:01

  117. core-ci voted on patch set 58 V -1 01/29/24, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52431

  118. Benjamin Kott uploaded patch set 59 V -1 01/29/24, 15:14

  119. core-ci voted on patch set 59 V -1 01/29/24, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52432

  120. Benjamin Franzke uploaded patch set 60 V -1 01/29/24, 15:58

  121. core-ci voted on patch set 60 V -1 01/29/24, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52439

  122. Benjamin Kott uploaded patch set 61 V -1 01/30/24, 07:23

  123. core-ci voted on patch set 61 V -1 01/30/24, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52481

  124. Benjamin Kott uploaded patch set 62 V -1 01/30/24, 11:43

  125. core-ci voted on patch set 62 V -1 01/30/24, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52489

  126. Benjamin Kott uploaded patch set 63 V -1 01/31/24, 15:44

  127. core-ci voted on patch set 63 V -1 01/31/24, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52559

  128. Benjamin Franzke uploaded patch set 64 V -1 02/01/24, 04:19

  129. core-ci voted on patch set 64 V -1 02/01/24, 04:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52565

  130. Benjamin Franzke uploaded patch set 65 V -1 02/01/24, 04:49

  131. core-ci voted on patch set 65 V +1 02/01/24, 04:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52566

  132. Benjamin Franzke uploaded patch set 66 V +1 02/01/24, 08:23

  133. core-ci voted on patch set 66 V +1 02/01/24, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52570

  134. Benjamin Franzke uploaded patch set 67 V +1 02/01/24, 09:08

  135. Benjamin Franzke uploaded patch set 68 02/01/24, 09:13

  136. core-ci voted on patch set 67 V +1 02/01/24, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52573

  137. core-ci voted on patch set 68 V +1 02/01/24, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52574

  138. Benjamin Kott uploaded patch set 69 V +1 02/01/24, 10:01

  139. core-ci voted on patch set 69 V +1 02/01/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52579

  140. Benjamin Franzke uploaded patch set 70 V +1 02/01/24, 16:33

  141. core-ci voted on patch set 70 V +1 02/01/24, 16:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52607

  142. Benjamin Franzke uploaded patch set 71 V +1 02/02/24, 10:01

  143. core-ci voted on patch set 71 V +1 02/02/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52627

  144. Benjamin Franzke uploaded patch set 72 V +1 02/02/24, 12:00

  145. core-ci voted on patch set 72 V +1 02/02/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52630

  146. Benjamin Kott uploaded patch set 73 V +1 02/02/24, 14:33

  147. core-ci voted on patch set 73 V -1 02/02/24, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52634

  148. Benjamin Franzke uploaded patch set 74 V -1 02/02/24, 15:41

  149. core-ci voted on patch set 74 V +1 02/02/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52636

  150. Benjamin Franzke uploaded patch set 75 V +1 02/03/24, 14:02

  151. core-ci voted on patch set 75 V +1 02/03/24, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52660

  152. Benjamin Franzke uploaded patch set 76 V +1 02/03/24, 14:58

  153. core-ci voted on patch set 76 V +1 02/03/24, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52661

  154. Benjamin Franzke uploaded patch set 77 V +1 02/04/24, 15:37

  155. core-ci voted on patch set 77 V -1 02/04/24, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52689

  156. Benjamin Franzke uploaded patch set 78 V -1 02/04/24, 16:08

  157. core-ci voted on patch set 78 V -1 02/04/24, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52690

  158. Benjamin Franzke uploaded patch set 79 V -1 02/04/24, 16:47

  159. core-ci voted on patch set 79 V -1 02/04/24, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52692

  160. Benjamin Franzke uploaded patch set 80 V -1 02/04/24, 16:54

  161. core-ci voted on patch set 80 V +1 02/04/24, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52693

  162. Benjamin Franzke uploaded patch set 81 V +1 02/05/24, 06:13

  163. core-ci voted on patch set 81 V +1 02/05/24, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52700

  164. Benjamin Kott uploaded patch set 82 V +1 02/05/24, 08:07

  165. core-ci voted on patch set 82 V +1 02/05/24, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52701

  166. Benjamin Franzke uploaded patch set 83 V +1 02/05/24, 11:19

  167. Benjamin Franzke commented on patch set 83 02/05/24, 11:19

    SelectTreeItem.php:20 Reply

    Done

    TreeItem.php:20 Reply

    Done
  168. core-ci voted on patch set 83 V +1 02/05/24, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52715

  169. Benjamin Kott uploaded patch set 84 V +1 02/05/24, 11:28

  170. core-ci voted on patch set 84 V +1 02/05/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52716

  171. Benjamin Kott uploaded patch set 85 V +1 02/05/24, 14:46

  172. core-ci voted on patch set 85 V -1 02/05/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52736

  173. Benjamin Kott uploaded patch set 86 V -1 02/05/24, 15:29

  174. core-ci voted on patch set 86 V -1 02/05/24, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52741

  175. Benjamin Franzke commented on patch set 86 02/06/24, 15:41

    Also ``` Resolves: #102125 ```
  176. Benjamin Kott uploaded patch set 87 V -1 02/07/24, 09:39

  177. Benjamin Kott rebased onto patch set 88 02/07/24, 09:39

  1. Benjamin Kott commented on patch set 88 02/07/24, 09:40

    Reply

    Done
  2. core-ci voted on patch set 87 V -1 02/07/24, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52840

  3. Benjamin Kott uploaded patch set 89 02/07/24, 09:46

  4. core-ci voted on patch set 88 V -1 02/07/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52841

  5. core-ci voted on patch set 89 V +1 02/07/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52842

  6. Benjamin Franzke commented on patch set 89 02/07/24, 09:58

    Modules.php:17

    @benni@typo3.org I know you wanted a compat layer here. Should we map these in typo3/sysext/backend/Classes/Module/BaseModule.php(?) with or without deprecation? Ideally I'd like to change these to `@typo3/backend/tree/page-tree-element.js` (adding js suffix), so i'd probably do that in a separate change later on.
  7. Andreas Kienast commented on patch set 89 02/07/24, 10:37

    WebServerConfigurationFileService.php:79

    Is this a drive-by fix for something different?
  8. Benjamin Kott commented on patch set 89 02/07/24, 11:03

    WebServerConfigurationFileService.php:79 Reply

    Rebase error, Done
  9. Benjamin Kott uploaded patch set 90 V +1 02/07/24, 13:17

  10. core-ci voted on patch set 90 V +1 02/07/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52863

  11. Benjamin Kott uploaded patch set 91 V +1 02/07/24, 13:37

  12. core-ci voted on patch set 91 V +1 02/07/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52864

  13. Andreas Kienast commented on patch set 91 02/07/24, 13:57

    file-list-dragdrop.ts:19

    left-over comment

    Feature-103043-ModernizeTreeRenderingAndImplementRTLAndDarkMode.rst:20

    The SVG tree was introduced in v9.
  14. Benjamin Kott uploaded patch set 92 V +1 02/07/24, 13:58

  15. Benjamin Kott uploaded patch set 93 02/07/24, 14:04

  16. Andreas Kienast commented on patch set 93 02/07/24, 14:05

    Feature-103043-ModernizeTreeRenderingAndImplementRTLAndDarkMode.rst:20 Reply

    Done
  17. core-ci voted on patch set 92 V +1 02/07/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52865

  18. Andreas Kienast commented on patch set 93 02/07/24, 14:08

    file-list-dragdrop.ts:19 Reply

    Done
  19. core-ci voted on patch set 93 V +1 02/07/24, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52868

  20. Andreas Kienast voted on patch set 93 CR +1 V +1 02/07/24, 14:11

  21. Frank Nägler voted on patch set 93 V +1 02/07/24, 14:14

  22. Frank Nägler voted on patch set 93 CR +1 02/07/24, 14:14

  23. Benjamin Franzke voted on patch set 93 CR +2 V +2 02/07/24, 14:16

  24. Benjamin Franzke commented on patch set 93 02/07/24, 14:16

    Modules.php:17 Reply

  25. Benjamin Franzke merged patch set 94 02/07/24, 14:17