81413[TASK] Remove TYPO3_CONF_VARS BE/flexformForceCDATA
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
- Stefan Bürk +1
- Simon Schaufelberger +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Garvin Hicking +1
- Stefan Bürk +1
- Simon Schaufelberger +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 11
- typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php+0 −3
- typo3/sysext/core/Classes/Serializer/Typo3XmlSerializer.php+0 −5
- typo3/sysext/core/Classes/Utility/GeneralUtility.php4+1 −5
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+0 −3
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102108-TCATypesbitmask_Settings.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-102146-RemovedLegacySettingBEflexformForceCDATA.rstnew+45 −0
- typo3/sysext/core/Tests/Unit/Serializer/Typo3XmlParserTest.php+0 −3
- typo3/sysext/core/Tests/Unit/Serializer/Typo3XmlSerializerTest.php+0 −22
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+2 −0
- typo3/sysext/install/Classes/SystemEnvironment/SetupCheck.php+0 −25
Review log 2430
Show 35 earlier messages
-
Christian Kuhn uploaded patch set 1 10/11/23, 16:45
-
core-ci voted on patch set 1 V -1 10/11/23, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47688
-
Christian Kuhn uploaded patch set 2
V -110/11/23, 17:13 -
core-ci voted on patch set 2 V +1 10/11/23, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47689
-
Christian Kuhn commented on patch set 1 10/11/23, 17:22
-
Garvin Hicking commented on patch set 2 10/11/23, 17:23
GeneralUtility.php:1219Accidentally removed this evaluation maybe? Doesnt seem related to the CDATA option? (I know its WIP, but since I read it "by squirrelaccident"...) -
Christian Kuhn uploaded patch set 3
V +110/11/23, 17:34 -
Christian Kuhn commented on patch set 3 10/11/23, 17:36
GeneralUtility.php:1219Replyshould be better now? -
Christian Kuhn uploaded patch set 4 10/11/23, 17:40
-
core-ci voted on patch set 3 V +1 10/11/23, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47690
-
core-ci voted on patch set 4 V +1 10/11/23, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47691
-
Christian Kuhn commented on patch set 4 10/11/23, 17:52
GeneralUtility.php:1219Replythe $dtype===string is always true due to the cast above, elseif never kicks in. useCDATA is always false, so the entire thing can go. -
Oliver Klee voted on patch set 4 V +1 CR +1 10/11/23, 18:19
-
Christian Kuhn commented on patch set 5
CR +1V +110/11/23, 18:24Published edit on patch set 4. -
Oliver Klee voted on patch set 5 V +1 CR +1 10/11/23, 18:26
-
Christian Kuhn commented on patch set 5 CR -1 10/11/23, 18:27
mom, dealing with details. -
core-ci voted on patch set 5 V +1 10/11/23, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47693
-
Simon Schaufelberger voted on patch set 5 CR +1 10/11/23, 20:00
-
Garvin Hicking commented on patch set 5 10/12/23, 06:34
Checked into it a bit. I believe this code here is definitely required to be kept: ``` $dType = gettype($v); if ($dType !== 'string' && !($options['disableTypeAttrib'] ?? false)) { $attr .= ' type="' . $dType . '"'; } ``` (slightly optimized). Otherwise, the returned output would be missing an output like `<arraykey type="(integer|boolean|double|float|NULL|object)">`. The option `disableTypeAttrib` is not set by default, so by default this output would always be included. BTW: I also grepped my source of all current TYPO3 packagist sources; the key "flexformForceCDATA" only occurs in two (irrelevant) extensions (fnagel/beautyofcode in an RST, friendsoftypo3/compatibility6 for you guessed it). 'useCDATA' occurs in: templavoila, compatibility6, franzholz/div2007, dmkebusinessgmbh/typo3-mkdam2fal - and I doubt these places have relevancy. -
Garvin Hicking commented on patch set 5 10/12/23, 06:39
For completion sake, 'disableTypeAttrib=2' (thus suppressing what has also been removed in this current state of the patch) is actively used in quite a few extensions (19), but there's no reverse indication on how many use the current default of depending on the attribute. -
Christian Kuhn uploaded patch set 6
CR +1V +110/12/23, 10:30 -
Christian Kuhn commented on patch set 5 CR -1 10/12/23, 10:31
Reply
agreed. thank you! i mixed up $stringValue and $v. good catch. i had a look at extension usages of flexformForceCDATA and useCDATA as well, looks as if this should not have impact. -
Garvin Hicking commented on patch set 6 V +1 CR +1 10/12/23, 10:34
👍 -
Simon Schaufelberger voted on patch set 6 V +1 CR +1 10/12/23, 10:36
-
core-ci voted on patch set 6 V +1 10/12/23, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47709
-
Oliver Klee voted on patch set 6 V +1 CR +1 10/12/23, 10:48
-
Stefan Bürk voted on patch set 6 V +1 CR +1 10/12/23, 11:02
-
Benni Mack voted on patch set 6 V +1 CR +1 10/12/23, 11:03
-
Christian Kuhn voted on patch set 6 V +2 CR +2 10/12/23, 11:07
-
Christian Kuhn merged patch set 7 10/12/23, 11:08
GeneralUtility.php:1214