81414[TASK] Clean up GifBuilder code
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Thomas Hohn +1
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Benni Mack uploaded patch set 1 10/12/23, 06:49
-
core-ci voted on patch set 1 V +1 10/12/23, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47701
-
Thomas Hohn commented on patch set 1 10/12/23, 07:50
-
Oliver Klee updated the commit message in patch set 2
V +110/12/23, 08:09 -
Stefan Bürk commented on patch set 2 10/12/23, 08:10
GifBuilder.php:1405ReplyBasically correct. Switch statements are fully valid, could be done. We avoid doing a lot of things in one patch and having a smaller patch concentrating on a task is appreciated. This change is abt cleanup related to a property usage. So let's not distrub that with a not necessary side change here now. -
Thomas Hohn voted on patch set 2 CR +1 10/12/23, 08:11
-
core-ci voted on patch set 2 V +1 10/12/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47702
-
Stefan Bürk voted on patch set 2 V +1 CR +1 10/12/23, 08:19
-
Oliver Klee voted on patch set 2 V +1 CR +1 10/12/23, 08:21
-
Stefan Bürk voted on patch set 2 V +2 CR +2 10/12/23, 08:29
-
Stefan Bürk merged patch set 3 10/12/23, 08:29
GifBuilder.php:1405