Review main Merged

81414[TASK] Clean up GifBuilder code

Benni Mack CR +2 V +2 Normal +71 −86 updated 10/12/23, 08:29

Commit message

This change avoids using the `$this->im`
property which is the resource pointer to the
`\GdImage` object.

In addition, the method `gifBuild()` is the only place
to deal with absolute path and the actual path
prefix, making `fileName()` easier to understand.

This change will then allow to advance with
Gdlib, adding support for webp at the next stage.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Thomas Hohn +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Benni Mack uploaded patch set 1 10/12/23, 06:49

  2. core-ci voted on patch set 1 V +1 10/12/23, 06:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47701

  3. Thomas Hohn commented on patch set 1 10/12/23, 07:50

    GifBuilder.php:1405

    You could use the match operator
  4. Oliver Klee updated the commit message in patch set 2 V +1 10/12/23, 08:09

  5. Stefan Bürk commented on patch set 2 10/12/23, 08:10

    GifBuilder.php:1405 Reply

    Basically correct. Switch statements are fully valid, could be done. We avoid doing a lot of things in one patch and having a smaller patch concentrating on a task is appreciated. This change is abt cleanup related to a property usage. So let's not distrub that with a not necessary side change here now.
  6. Thomas Hohn voted on patch set 2 CR +1 10/12/23, 08:11

  7. core-ci voted on patch set 2 V +1 10/12/23, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47702

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 10/12/23, 08:19

  9. Oliver Klee voted on patch set 2 V +1 CR +1 10/12/23, 08:21

  10. Stefan Bürk voted on patch set 2 V +2 CR +2 10/12/23, 08:29

  11. Stefan Bürk merged patch set 3 10/12/23, 08:29